Skip to content

Conversation

alemagio
Copy link
Contributor

@alemagio alemagio commented Oct 15, 2020

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

#2

Motivation and Context

How Has This Been Tested?

I tried several times manually but I will also keep testing it.

Screenshots (if appropriate):

Checklist:

  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I added a picture of a cute animal cause it's fun

image

NOTE:
As you can see I installed adm-zip, it has no dependency and allowed me to unzip the file easily (even if, apparently there is no way to rename the zipEntry, they also have an open issue, maybe I'll take that one when I can 😄 )
I tried using zlib but had no success, if you have any suggestion feel free to tell me

I pushed it to be sure we are on the same page and to have feedback

@lirantal
Copy link
Collaborator

Looks good.
Now to make this actually work as part of the process of creating and publishing the library we need to call the build script (i.e: npm run build) in the github actions workflow, right before we publish. Can you add it?

@alemagio
Copy link
Contributor Author

alemagio commented Oct 20, 2020

I simply added to the workflow.
I have one question:
what do we want to do if, for whatever reason, something does wrong while downloading the zip?
I think we should keep the old one right?

@lirantal
Copy link
Collaborator

If something is wrong with the zip (non existent etc) then it means that release will fail because this step will fail https://twitter.com/maxbeatty/status/1182370039032205313, right?

@lirantal
Copy link
Collaborator

@alemagio looks good to me, let's merge it in and see!

@lirantal lirantal merged commit 9c2c377 into OWASP:master Oct 20, 2020
@alemagio
Copy link
Contributor Author

If something is wrong with the zip (non existent etc) then it means that release will fail because this step will fail https://twitter.com/maxbeatty/status/1182370039032205313, right?

I think so.

@alemagio looks good to me, let's merge it in and see!

I like your approach 😂

@github-actions
Copy link

🎉 This PR is included in version 1.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lirantal
Copy link
Collaborator

Looks like it works well @alemagio

Comparing https://unpkg.com/browse/[email protected]/raw/ with https://unpkg.com/browse/[email protected]/raw/ looks like we're getting more CWEs :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants