-
Notifications
You must be signed in to change notification settings - Fork 11
feat: it is now possible to retrieve memberships #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I added a test with the same example provided by the issue, the results shows 4 memberships instead of the 2 shown on https://cwe.mitre.org/data/definitions/778.html |
d25bbec
to
2511d16
Compare
Looks like I missed this one @alemagio, apologies on the delay. I've been behind on things (mac broke so sent it off to the labs!). I'll get to this soon! |
@lirantal no worries, as a seasoned Linux user I blame the mac anyway 😂 |
@alemagio I think the way to find just the 2 categories that we see at the end of that 778 CWE page is to traverse through all the For 778, you should indeed find only 2 categories that have 778 as part of it, per the 778 CWE webpage. Does it make sense? |
@lirantal I found it in 4 categories, I mean, I'm still learning so feel free to tell me if I'm doing something wrong 😅 |
Oh, I might have missed them! |
So we're good with this PR as is taking the data from https://github.com/OWASP/cwe-sdk-javascript/pull/7/files#diff-c7ee1fe8e949317fd2d30127d95e1ea1ec30cd65ccb2a2e7c427fd4ca05284a3R16 ? |
Yes, when we build |
Ok to go with the ID for now. I'll go ahead and merge. Thanks @alemagio 🙏 |
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Now build creates a new json file similar to the hierarchy one but containing the memberships info of the weaknesses.
Types of changes
Related Issue
Fixes #1
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: