refactor(semantic): Program visitor leave scope before node (#4369)

overlookmotel · overlookmotel · commit f7b9ada372b8 · 2024-07-19T16:32:27.000Z
Bring the order of calls in `SemanticBuilder::visit_program` into line with `Visit`'s `walk_program`.
diff --git a/crates/oxc_semantic/src/builder.rs b/crates/oxc_semantic/src/builder.rs
@@ -563,8 +563,8 @@ impl<'a> Visit<'a> for SemanticBuilder<'a> {
         control_flow!(self, |cfg| cfg.release_error_harness(error_harness));
         /* cfg */
 
-        self.leave_node(kind);
         self.leave_scope();
+        self.leave_node(kind);
     }
 
     fn visit_break_statement(&mut self, stmt: &BreakStatement<'a>) {

Original file line number	Diff line number	Diff line change
`@@ -563,8 +563,8 @@ impl<'a> Visit<'a> for SemanticBuilder<'a> {`
`563`	`563`	`control_flow!(self, \|cfg\| cfg.release_error_harness(error_harness));`
`564`	`564`	`/* cfg */`
`565`	`565`
`566`		`- self.leave_node(kind);`
`567`	`566`	`self.leave_scope();`
	`567`	`+ self.leave_node(kind);`
`568`	`568`	`}`
`569`	`569`
`570`	`570`	`fn visit_break_statement(&mut self, stmt: &BreakStatement<'a>) {`