From 7a51b41bdf443dcd68cc5805543986e686c2bea4 Mon Sep 17 00:00:00 2001 From: David Laehnemann Date: Fri, 7 Feb 2020 15:34:32 +0100 Subject: [PATCH] fix double-negation in gene_column check upon manual change of pval_aggregate in sleuth_object --- R/sleuth.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/sleuth.R b/R/sleuth.R index 4025979..35451d3 100644 --- a/R/sleuth.R +++ b/R/sleuth.R @@ -1291,7 +1291,7 @@ gene_from_gene <- function(obj, gene_colname, gene_name) { } else { obj[[name]] <- value } - } else if (name == "pval_aggregate" && value && !is.null(obj$gene_column)) { + } else if (name == "pval_aggregate" && value && is.null(obj$gene_column)) { stop("You set 'pval_aggregate' to TRUE, but no 'gene_column' is set. Please set a 'gene_column' first.") } else if (name == "pval_aggregate" && value && obj$gene_mode) { warning("You set 'pval_aggregate' to TRUE, but 'gene_mode' is also TRUE. Setting 'gene_mode' to FALSE.",