Skip to content

Conversation

@tacaswell
Copy link
Contributor

cython/cython#5830 /
d7e95912b6ed7d20e190fbf1aecb9f2a997d479 in cython removed long as a valid type in favor of int.

Without this change pandas fails to cythonize under the default branch of cython.

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

cython/cython#5830 /
d7e95912b6ed7d20e190fbf1aecb9f2a997d479 in cython removed
long as a valid type in favor of int.
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcoGorelli MarcoGorelli added this to the 2.2 milestone Nov 23, 2023
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tacaswell !

@MarcoGorelli MarcoGorelli merged commit 4744064 into pandas-dev:main Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants