TST (string dtype): remove usage of 'string[pyarrow_numpy]' alias #59758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Sep 9, 2024
| obj = Series(["foo", "foo", None, "foo"], dtype=dtype) | ||
| obj = Series(["foo", "foo", None, "foo"], dtype=string_dtype_no_object) | ||
| result = obj.rank(method="first") | ||
| exp_dtype = "Int64" if string_dtype_no_object.na_value is pd.NA else "float64" |
Member
There was a problem hiding this comment.
Hmm why are these int64 for some types now? I think float is required for the return type to allow for some tiebreakers
Member
Author
There was a problem hiding this comment.
Ah, good point! But so that is an existing bug in the ArrowExtensionArray implementation then, because this test was already asserting Int64 (I just rewrote it a bit, but in the removed parametrization a few lines above there is already this dtype)
Member
Author
There was a problem hiding this comment.
Opened a separate PR to address this -> #59768
…remove-usage-pyarrow_numpy-alias
WillAyd
approved these changes
Sep 9, 2024
jorisvandenbossche
deleted the
string-dtype-tests-remove-usage-pyarrow_numpy-alias
branch
jorisvandenbossche
added a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Oct 10, 2024
jorisvandenbossche
added a commit
that referenced
this pull request
Oct 10, 2024
46 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all remaining usages of
"string[pyarrow_numpy]", the to-be deprecated string alias for the future default string dtype (will then actually deprecate it in a follow-up PR).xref #54792