fix: Local datastore query with `containedIn` not working when field is an array #1666

dplewis · 2023-01-25T00:12:20Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

Similar to parse-community/parse-server#8128

Closes: Added additional test case for parse-community/parse-server#8335

Approach

TODOs before merging

Add tests
Add changes to documentation (guides, repository pages, in-code descriptions)

parse-github-assistant · 2023-01-25T00:12:22Z

I will reformat the title to use the proper commit message syntax.

parse-github-assistant · 2023-01-25T00:12:25Z

Thanks for opening this pull request!

❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

codecov · 2023-01-25T00:18:58Z

Codecov Report

Base: 99.89% // Head: 99.89% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7bce5fc) compared to base (e9a2cc9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##            alpha    #1666   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          61       61           
  Lines        5973     5977    +4     
  Branches     1367     1369    +2     
=======================================
+ Hits         5967     5971    +4     
  Misses          6        6

Impacted Files	Coverage Δ
src/OfflineQuery.js	`99.68% <100.00%> (+<0.01%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mtrezza · 2023-01-25T13:06:13Z

Thanks for the PR; could you rephrase the PR title to make it easier to understand in the changelog what this actually fixes?

The 2 references are related to LiveQuery - is this also LiveQuery related?

dplewis · 2023-01-25T17:50:01Z

@mtrezza The LocalDatastore is internally code copied from LiveQuery meaning queries that LiveQuery supports the LocalDatastore should support too. Those are just additional test cases that doesn't exist server side.

mtrezza · 2023-01-25T18:56:34Z

How would you best describe the fix in src/OfflineQuery.js?

Local datastore not working properly for Parse.Query.containedIn where field is an array

Or something more specific?

dplewis · 2023-01-25T23:49:09Z

How would you best describe the fix in src/OfflineQuery.js?

It's the same fix as the QueryTools.js in the latest 5.4.0 release of the server

https://github.com/parse-community/parse-server/pull/8128/files#diff-13c52f9da4d37c7dc0bd3e9e845716de38a13e2a8632465ea167422762d5a9b6

dplewis · 2023-01-26T00:17:15Z

Or something more specific?

For non array fields you are comparing a single value against an array. This fix checks a array against an array recursively. As I write this I realized that nonContainedIn is broken and will return always return an object.

Without this fix we would have to rely on.

haystack.indexOf(needle) > -1

Array.indexOf(Array) will always return -1

mtrezza · 2023-01-26T00:21:54Z

The other PR is called "fix: liveQuery with containedIn not working when object field is an array". So how about this:

fix: Local datastore query with containedIn not working when field is an array

What do you conclude from the nonContainedIn? I haven't looked into the logic so far...

dplewis · 2023-01-26T00:33:32Z

@mtrezza I write a few additional test cases, I also think there might be an issue with containedBy queries.

dplewis · 2023-01-26T22:38:27Z

@mtrezza This is ready for review

mtrezza · 2023-01-26T22:45:03Z

Re-running CI

I'm curious about these fails: https://github.com/parse-community/Parse-SDK-JS/actions/runs/4019619971/jobs/6906679057; it seems a connection error, do you have any idea what that could be since you've been looking at the flaky tests?

dplewis · 2023-01-27T00:36:41Z

it seems a connection error, do you have any idea what that could be since you've been looking at the flaky tests?

@mtrezza I suspect it might be an issue with reconfigureServer. allowCustomObjectId tests seem most common but I have seen eventuallyQueue tests also fail with his error. You can see where the first occurrence of the error is thrown.

# [4.0.0-alpha.6](4.0.0-alpha.5...4.0.0-alpha.6) (2023-01-27) ### Bug Fixes * Local datastore query with `containedIn` not working when field is an array ([#1666](#1666)) ([2391bff](2391bff))

parseplatformorg · 2023-01-27T09:33:14Z

🎉 This change has been released in version 4.0.0-alpha.6

## [4.0.1-beta.1](4.0.0...4.0.1-beta.1) (2023-01-31) ### Bug Fixes * Local datastore query with `containedIn` not working when field is an array ([#1666](#1666)) ([2391bff](2391bff)) * Request execution time keeps increasing over time when using `Parse.Object.extend` ([#1682](#1682)) ([f555c43](f555c43))

parseplatformorg · 2023-01-31T00:19:44Z

🎉 This change has been released in version 4.0.1-beta.1

## [4.0.1](4.0.0...4.0.1) (2023-01-31) ### Bug Fixes * Local datastore query with `containedIn` not working when field is an array ([#1666](#1666)) ([2391bff](2391bff)) * Request execution time keeps increasing over time when using `Parse.Object.extend` ([#1682](#1682)) ([f555c43](f555c43))

parseplatformorg · 2023-01-31T02:25:23Z

🎉 This change has been released in version 4.0.1

fix: localDatastore query.containedIn not working when field is an array

1c56ae4

parse-github-assistant bot changed the title ~~fix: localDatastore query.containedIn not working when field is an array~~ fix: LocalDatastore query.containedIn not working when field is an array Jan 25, 2023

dplewis requested a review from a team January 25, 2023 04:17

mtrezza changed the title ~~fix: LocalDatastore query.containedIn not working when field is an array~~ fix: LocalDatastore Parse.Query.containedIn not working when field is an array Jan 25, 2023

mtrezza changed the title ~~fix: LocalDatastore Parse.Query.containedIn not working when field is an array~~ fix: Local datastore Parse.Query.containedIn not working when field is an array Jan 25, 2023

mtrezza changed the title ~~fix: Local datastore Parse.Query.containedIn not working when field is an array~~ fix: Local datastore query with containedIn not working when field is an array Jan 26, 2023

dplewis added 3 commits January 26, 2023 12:40

Merge branch 'master' into containedIn-array

33eaae2

improve tests

22a7ab2

remove fit

7bce5fc

dplewis requested a review from a team January 26, 2023 22:21

mtrezza merged commit 2391bff into parse-community:alpha Jan 27, 2023

parseplatformorg added the state:released-alpha Released as alpha version label Jan 27, 2023

dplewis mentioned this pull request Jan 27, 2023

ci: Fix flaky tests due to open server connection #1670

Merged

4 tasks

parseplatformorg added the state:released-beta Released as beta version label Jan 31, 2023

parseplatformorg added the state:released Released as stable version label Jan 31, 2023

Uh oh!

fix: Local datastore query with containedIn not working when field is an array #1666

fix: Local datastore query with containedIn not working when field is an array #1666

Uh oh!

Conversation

dplewis commented Jan 25, 2023

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

Uh oh!

parse-github-assistant bot commented Jan 25, 2023

Uh oh!

parse-github-assistant bot commented Jan 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thanks for opening this pull request!

Uh oh!

codecov bot commented Jan 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mtrezza commented Jan 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dplewis commented Jan 25, 2023

Uh oh!

mtrezza commented Jan 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dplewis commented Jan 25, 2023

Uh oh!

dplewis commented Jan 26, 2023

Uh oh!

mtrezza commented Jan 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dplewis commented Jan 26, 2023

Uh oh!

dplewis commented Jan 26, 2023

Uh oh!

mtrezza commented Jan 26, 2023

Uh oh!

dplewis commented Jan 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parseplatformorg commented Jan 27, 2023

Uh oh!

parseplatformorg commented Jan 31, 2023

Uh oh!

parseplatformorg commented Jan 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: Local datastore query with `containedIn` not working when field is an array #1666

fix: Local datastore query with `containedIn` not working when field is an array #1666

parse-github-assistant bot commented Jan 25, 2023 •

edited

Loading

codecov bot commented Jan 25, 2023 •

edited

Loading

mtrezza commented Jan 25, 2023 •

edited

Loading

mtrezza commented Jan 25, 2023 •

edited

Loading

mtrezza commented Jan 26, 2023 •

edited

Loading

dplewis commented Jan 27, 2023 •

edited

Loading