GeoPoint storing as strings if constructed by a string array

[Krilwya]

I encountered an issue using near after migrating string gps positions into GeoPoints.

So basically when you do something like :
new Parse.GeoPoint(["48.84023", "2.33334"])
it returns :
ParseGeoPoint {_latitude: "48.84023", _longitude: "2.33334"}

So it passes through the constuctor of the Geopoint, it shall be more efficient in the _validate method of the Geopoint to check typeof latitude == "number" and same with longitude or try to cast those into parseFloat or whatever.

Knowing all of that, having string geopoints break all near, withinKilometers, and so on functions as mongodb would look for floats.

[flovilmart]

@Krilwya are you willing to open a PR with the failing test and add additional validation?

[Krilwya]

Sure, I runned the jest test on my changes locally, that succeed them, if you could explain to me the procedure to ask for a pull request as it's my first time on github that'd be great. I am only used to vsts.

[flovilmart]

Did you check the github pull request guide? https://help.github.com/articles/creating-a-pull-request/

Usually:

1. Fork the project
2. in your local clone, add your remote with git remote add fork https://github.com/USENAME/Parse-SDK-JS.git
3. CreAte a new branch: git checkout -b my-feature-branch-name
4. Commit your changes git add .; git commit -a
5. Push to your fork: git push fork my-feature-branch-name
6. Open github.com/Parse-community/Parse-SDK-JS and you should be able to open the Pull request

[Krilwya]

Thank you for your answer, I think I did all the requirement to do so. If you need anything else to verify or something seems wrong I'd be pleased to hear from you.

[dplewis]

Closing via #671