Fix channel leave on unjoined channels. Closes #5779

Author: chrismccord

CHANGELOG.md

@@ -48,6 +48,9 @@ future styling).
 
 ## 1.7.12
 
+### JavaScript Client Bug Fixes
+  * Fix all unjoined channels from being removed from the socket when channel leave is called on any single unjoined channel instance
+
 ### Enhancements
   * [phx.gen.auth] Add enhanced session fixation protection.
     For applications whichs previously used `phx.gen.auth`, the following line can be added to the `renew_session` function in the auth module:

assets/js/phoenix/socket.js

@@ -543,7 +543,7 @@ export default class Socket {
    */
   remove(channel){
     this.off(channel.stateChangeRefs)
-    this.channels = this.channels.filter(c => c.joinRef() !== channel.joinRef())
+    this.channels = this.channels.filter(c => c !== channel)
   }
 
   /**

priv/static/phoenix.cjs.js

@@ -1461,7 +1461,7 @@ var Phoenix = (() => {
      */
     remove(channel) {
       this.off(channel.stateChangeRefs);
-      this.channels = this.channels.filter((c) => c.joinRef() !== channel.joinRef());
+      this.channels = this.channels.filter((c) => c !== channel);
     }
     /**
      * Removes `onOpen`, `onClose`, `onError,` and `onMessage` registrations.

priv/static/phoenix.cjs.js.map

@@ -1432,7 +1432,7 @@ var Socket = class {
    */
   remove(channel) {
     this.off(channel.stateChangeRefs);
-    this.channels = this.channels.filter((c) => c.joinRef() !== channel.joinRef());
+    this.channels = this.channels.filter((c) => c !== channel);
   }
   /**
    * Removes `onOpen`, `onClose`, `onError,` and `onMessage` registrations.