Support for new in initializers

Author: ondrejmirtes

composer.json

@@ -23,7 +23,7 @@
 		"nette/utils": "^3.1.3",
 		"nikic/php-parser": "4.13.1",
 		"ondram/ci-detector": "^3.4.0",
-		"ondrejmirtes/better-reflection": "4.3.79",
+		"ondrejmirtes/better-reflection": "4.3.80",
 		"phpstan/php-8-stubs": "^0.1.23",
 		"phpstan/phpdoc-parser": "^1.2.0",
 		"react/child-process": "^0.6.4",

composer.lock

@@ -39,6 +39,8 @@ public static function getTypeFromValue($value): Type
 				$arrayBuilder->setOffsetValueType(self::getTypeFromValue($k), self::getTypeFromValue($v));
 			}
 			return $arrayBuilder->getArray();
+		} elseif (is_object($value)) {
+			return new ObjectType(get_class($value));
 		}
 
 		return new MixedType();

src/Type/ConstantTypeHelper.php

@@ -542,6 +542,15 @@ public function dataFileAsserts(): iterable
 
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-2760.php');
 
+		if (PHP_VERSION_ID >= 80100 || self::$useStaticReflectionProvider) {
+			yield from $this->gatherAssertTypes(__DIR__ . '/data/new-in-initializers.php');
+
+			if (PHP_VERSION_ID >= 80100) {
+				define('TEST_OBJECT_CONSTANT', new \stdClass());
+				yield from $this->gatherAssertTypes(__DIR__ . '/data/new-in-initializers-runtime.php');
+			}
+		}
+
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/filesystem-functions.php');
 	}
 

tests/PHPStan/Analyser/NodeScopeResolverTest.php

@@ -0,0 +1,7 @@
+<?php // lint >= 8.1
+
+namespace NewInInitializers;
+
+use function PHPStan\Testing\assertType;
+
+assertType('stdClass', TEST_OBJECT_CONSTANT);

tests/PHPStan/Analyser/data/new-in-initializers-runtime.php

@@ -0,0 +1,46 @@
+<?php // lint >= 8.1
+
+namespace NewInInitializers;
+
+use function PHPStan\Testing\assertType;
+
+class Foo
+{
+
+	/**
+	 * @template T of object
+	 * @param T $test
+	 * @return T
+	 */
+	public function doFoo(
+		object $test = new \stdClass()
+	): object
+	{
+		return $test;
+	}
+
+	#[\Test(new \stdClass())]
+	public function doBar()
+	{
+		assertType(\stdClass::class, $this->doFoo());
+		assertType('$this(NewInInitializers\Foo)', $this->doFoo($this));
+		assertType(Bar::class, $this->doFoo(new Bar()));
+	}
+
+}
+
+class Bar extends Foo
+{
+
+	public function doBar()
+	{
+
+	}
+
+	public function doBaz()
+	{
+		static $o = new \stdClass();
+		assertType('mixed', $o);
+	}
+
+}

tests/PHPStan/Analyser/data/new-in-initializers.php

@@ -114,6 +114,10 @@ public function dataConst(): array
 				'const_with_dir_const',
 				str_replace('\\', '/', __DIR__ . '/data'),
 			],
+			[
+				'OPTIMIZED_SFSL_OBJECT_CONSTANT',
+				new \stdClass(),
+			],
 		];
 	}
 
@@ -130,7 +134,7 @@ public function testConst(string $constantName, $value): void
 		$constantReflector = new ConstantReflector($locator, $classReflector);
 		$constant = $constantReflector->reflect($constantName);
 		$this->assertSame($constantName, $constant->getName());
-		$this->assertSame($value, $constant->getValue());
+		$this->assertEquals($value, $constant->getValue());
 	}
 
 	public function dataConstUnknown(): array

tests/PHPStan/Reflection/BetterReflection/SourceLocator/OptimizedSingleFileSourceLocatorTest.php

@@ -10,3 +10,5 @@
 define('TEST_VARIABLE', $foo);
 
 define('const_with_dir_const', __DIR__);
+
+define('OPTIMIZED_SFSL_OBJECT_CONSTANT', new \stdClass());

tests/PHPStan/Reflection/BetterReflection/SourceLocator/data/const.php

@@ -45,4 +45,18 @@ public function testBug2573(): void
 		$this->analyse([__DIR__ . '/data/bug-2573.php'], []);
 	}
 
+	public function testNewInInitializers(): void
+	{
+		if (PHP_VERSION_ID < 80100 && !self::$useStaticReflectionProvider) {
+			$this->markTestSkipped('Test requires PHP 8.0.');
+		}
+
+		$this->analyse([__DIR__ . '/data/new-in-initializers.php'], [
+			[
+				'Default value of the parameter #1 $i (stdClass) of method MethodNewInInitializers\Foo::doFoo() is incompatible with type int.',
+				11,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Methods/IncompatibleDefaultParameterTypeRuleTest.php

@@ -0,0 +1,16 @@
+<?php // lint >= 8.1
+
+namespace MethodNewInInitializers;
+
+class Foo
+{
+
+	/**
+	 * @param int $i
+	 */
+	public function doFoo($i = new \stdClass(), object $o = new \stdClass())
+	{
+
+	}
+
+}