Promoted properties do not have a default value

Author: ondrejmirtes

src/Analyser/NodeScopeResolver.php

@@ -521,7 +521,7 @@ private function processStmtNode(
 						$param->var->name,
 						$param->flags,
 						$param->type,
-						$param->default,
+						null,
 						$phpDoc,
 						true,
 						$param

tests/PHPStan/Rules/Methods/IncompatibleDefaultParameterTypeRuleTest.php

@@ -59,4 +59,22 @@ public function testNewInInitializers(): void
 		]);
 	}
 
+	public function testDefaultValueForPromotedProperty(): void
+	{
+		if (!self::$useStaticReflectionProvider) {
+			$this->markTestSkipped('Test requires static reflection.');
+		}
+
+		$this->analyse([__DIR__ . '/data/default-value-for-promoted-property.php'], [
+			[
+				'Default value of the parameter #1 $foo (string) of method DefaultValueForPromotedProperty\Foo::__construct() is incompatible with type int.',
+				9,
+			],
+			[
+				'Default value of the parameter #2 $foo (string) of method DefaultValueForPromotedProperty\Foo::__construct() is incompatible with type int.',
+				10,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Properties/data/default-value-for-promoted-property.php renamed to tests/PHPStan/Rules/Methods/data/default-value-for-promoted-property.php

@@ -47,22 +47,4 @@ public function testDefaultValueForNativePropertyType(): void
 		]);
 	}
 
-	public function testDefaultValueForPromotedProperty(): void
-	{
-		if (!self::$useStaticReflectionProvider) {
-			$this->markTestSkipped('Test requires static reflection.');
-		}
-
-		$this->analyse([__DIR__ . '/data/default-value-for-promoted-property.php'], [
-			[
-				'Property DefaultValueForPromotedProperty\Foo::$foo (int) does not accept default value of type string.',
-				9,
-			],
-			[
-				'Property DefaultValueForPromotedProperty\Foo::$foo (int) does not accept default value of type string.',
-				10,
-			],
-		]);
-	}
-
 }

tests/PHPStan/Rules/Properties/DefaultValueTypesAssignedToPropertiesRuleTest.php

@@ -46,6 +46,10 @@ public function dataRule(): array
 						'Readonly property cannot have a default value.',
 						10,
 					],
+					[
+						'Readonly properties are supported only on PHP 8.1 and later.',
+						16,
+					],
 				],
 			],
 			[

tests/PHPStan/Rules/Properties/ReadOnlyPropertyRuleTest.php

@@ -10,3 +10,10 @@ class Foo
 	private readonly int $baz = 0;
 
 }
+
+final class ErrorResponse
+{
+	public function __construct(public readonly string $message = '')
+	{
+	}
+}