use benevolent union for stream_get_contents() to prevent strict-rule errors (#4146)

Author: staabm

resources/functionMap.php

@@ -11366,7 +11366,7 @@
 'stream_filter_prepend' => ['resource|false', 'stream'=>'resource', 'filtername'=>'string', 'read_write='=>'int', 'params='=>'mixed'],
 'stream_filter_register' => ['bool', 'filtername'=>'string', 'classname'=>'string'],
 'stream_filter_remove' => ['bool', 'stream_filter'=>'resource'],
-'stream_get_contents' => ['string|false', 'source'=>'resource', 'maxlen='=>'int', 'offset='=>'int'],
+'stream_get_contents' => ['__benevolent<string|false>', 'source'=>'resource', 'maxlen='=>'int', 'offset='=>'int'],
 'stream_get_filters' => ['list<string>'],
 'stream_get_line' => ['string|false', 'stream'=>'resource', 'maxlen'=>'int', 'ending='=>'string'],
 'stream_get_meta_data' => ['array{timed_out:bool,blocked:bool,eof:bool,unread_bytes:int,stream_type:string,wrapper_type:string,wrapper_data:mixed,mode:string,seekable:bool,uri?:string,mediatype?:string,base64?:bool}', 'fp'=>'resource'],

src/Type/Php/StreamGetContentsFunctionReturnTypeExtension.php

@@ -3653,12 +3653,7 @@ public function testBug3396(): void
 		$this->checkUnionTypes = true;
 		$this->checkExplicitMixed = false;
 
-		$this->analyse([__DIR__ . '/data/bug-3396.php'], [
-			[
-				'Parameter #1 $s of method Bug3396\HelloWorld::takesString() expects string, string|false given.',
-				18,
-			],
-		]);
+		$this->analyse([__DIR__ . '/data/bug-3396.php'], []);
 	}
 
 }