Add "index" field to keys to account for extra wildcard groups #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per expressjs/express#2617 when you use a * as a wildcard in a path it'll generate a (.*) which creates an extra match group when you run the regular expression. The index value allows you to to account for this in consuming code in an API compatible way.
I think that in future API breaking versions, wildcard groups should probably be full on keys with some metadata.