Refactor tool installation logic to remove timeout and retries

Removed subprocess timeout and retry limit for tool installation, allowing installations to complete on slow networks.

Author: Jason2866

platform.py

@@ -41,12 +41,6 @@
 from platformio.package.manager.tool import ToolPackageManager
 
 # Constants
-try:
-    with open('/proc/device-tree/model') as f:
-        SUBPROCESS_TIMEOUT = 900 if 'raspberry pi' in f.read().lower() else 300
-except:
-    SUBPROCESS_TIMEOUT = 300
-RETRY_LIMIT = 3
 DEFAULT_DEBUG_SPEED = "5000"
 DEFAULT_APP_OFFSET = "0x10000"
 tl_install_name = "tool-esp_install"
@@ -91,10 +85,17 @@
 if IS_WINDOWS:
     os.environ["PLATFORMIO_SYSTEM_TYPE"] = "windows_amd64"
 
+# exit without git
+if not shutil.which("git"):
+    print("Git not found in PATH, please install Git.", file=sys.stderr)
+    print("Git is needed for Platform espressif32 to work.", file=sys.stderr)
+    raise SystemExit(1)
+
 # Set IDF_TOOLS_PATH to Pio core_dir
 PROJECT_CORE_DIR=ProjectConfig.get_instance().get("platformio", "core_dir")
 IDF_TOOLS_PATH=os.path.join(PROJECT_CORE_DIR)
 os.environ["IDF_TOOLS_PATH"] = IDF_TOOLS_PATH
+os.environ['IDF_PATH'] = ""
 
 # Global variables
 python_exe = get_pythonexe_path()
@@ -385,7 +386,11 @@ def _check_tool_status(self, tool_name: str) -> Dict[str, bool]:
         }
 
     def _run_idf_tools_install(self, tools_json_path: str, idf_tools_path: str) -> bool:
-        """Execute idf_tools.py install command with timeout and error handling."""
+        """
+        Execute idf_tools.py install command.
+        Note: No timeout is set to allow installations to complete on slow networks.
+        The tool-esp_install handles the retry logic.
+        """
         cmd = [
             python_exe,
             idf_tools_path,
@@ -397,11 +402,11 @@ def _run_idf_tools_install(self, tools_json_path: str, idf_tools_path: str) -> b
         ]
 
         try:
+            logger.info(f"Installing tools via idf_tools.py (this may take several minutes)...")
             result = subprocess.run(
                 cmd,
                 stdout=subprocess.DEVNULL,
                 stderr=subprocess.DEVNULL,
-                timeout=SUBPROCESS_TIMEOUT,
                 check=False
             )
 
@@ -412,9 +417,6 @@ def _run_idf_tools_install(self, tools_json_path: str, idf_tools_path: str) -> b
             logger.debug("idf_tools.py executed successfully")
             return True
 
-        except subprocess.TimeoutExpired:
-            logger.error(f"Timeout in idf_tools.py after {SUBPROCESS_TIMEOUT}s")
-            return False
         except (subprocess.SubprocessError, OSError) as e:
             logger.error(f"Error in idf_tools.py: {e}")
             return False
@@ -454,14 +456,8 @@ def _check_tool_version(self, tool_name: str) -> bool:
             logger.error(f"Error reading package data for {tool_name}: {e}")
             return False
 
-    def install_tool(self, tool_name: str, retry_count: int = 0) -> bool:
-        """Install a tool with optimized retry mechanism."""
-        if retry_count >= RETRY_LIMIT:
-            logger.error(
-                f"Installation of {tool_name} failed after {RETRY_LIMIT} attempts"
-            )
-            return False
-
+    def install_tool(self, tool_name: str) -> bool:
+        """Install a tool."""
         self.packages[tool_name]["optional"] = False
         paths = self._get_tool_paths(tool_name)
         status = self._check_tool_status(tool_name)
@@ -473,7 +469,7 @@ def install_tool(self, tool_name: str, retry_count: int = 0) -> bool:
         # Case 2: Tool already installed, version check
         if (status['has_idf_tools'] and status['has_piopm'] and
                 not status['has_tools_json']):
-            return self._handle_existing_tool(tool_name, paths, retry_count)
+            return self._handle_existing_tool(tool_name, paths)
 
         logger.debug(f"Tool {tool_name} already configured")
         return True
@@ -501,9 +497,7 @@ def _install_with_idf_tools(self, tool_name: str, paths: Dict[str, str]) -> bool
         logger.info(f"Tool {tool_name} successfully installed")
         return True
 
-    def _handle_existing_tool(
-        self, tool_name: str, paths: Dict[str, str], retry_count: int
-    ) -> bool:
+    def _handle_existing_tool(self, tool_name: str, paths: Dict[str, str]) -> bool:
         """Handle already installed tools with version checking."""
         if self._check_tool_version(tool_name):
             # Version matches, use tool
@@ -518,7 +512,7 @@ def _handle_existing_tool(
         # Remove the main tool directory (if it still exists after cleanup)
         safe_remove_directory(paths['tool_path'])
 
-        return self.install_tool(tool_name, retry_count + 1)
+        return self.install_tool(tool_name)
 
     def _configure_arduino_framework(self, frameworks: List[str]) -> None:
         """Configure Arduino framework dependencies."""