fix traceNames with frames (#1932)

* * fix traceNames

* update NEWS

* update tests figs from docker image

* remove type = "scatter" and update tests SVGs

Author: FrankBornais

NEWS.md

@@ -3,6 +3,7 @@
 ## BUG FIXES
 
 * `group_by.plotly()` now properly retains crosstalk information across `{dplyr}` versions (#1920).
+* Fixes some issues with `name` and `frames` when both attributes are specified. (#1903 and #1618).
 
 # 4.9.3
 

R/plotly_build.R

@@ -484,12 +484,14 @@ registerFrames <- function(p, frameMapping = NULL) {
     d <- lapply(d, function(tr) { tr$visible <- tr$visible %||% TRUE; tr })
 
     # if this frame is missing a trace name, supply an invisible one
-    traceNamesMissing <- setdiff(frameTraceNames, sapply(d, "[[", "name"))
+    traceNamesMissing <- setdiff(frameTraceNames, unlist(lapply(d, "[[", "name")))
     for (j in traceNamesMissing) {
       idx <- vapply(p$x$data, function(tr) isTRUE(tr[["name"]] == j), logical(1))
-      idx <- which(idx)[[1]]
-      invisible <- modify_list(p$x$data[[idx]], list(visible = FALSE))
-      d <- c(d, list(invisible))
+      if (any(idx)){
+        idx <- which(idx)[[1]]
+        invisible <- modify_list(p$x$data[[idx]], list(visible = FALSE))
+        d <- c(d, list(invisible))
+      }
     }
     p$x$frames[[i]] <- list(
       name = as.character(format(nm)),

tests/figs/density2d/density2d.svg

@@ -1,3 +1,3 @@
 - vdiffr-svg-engine: 1.0
 - vdiffr: 0.3.3.9000
-- freetypeharfbuzz: 0.2.5
+- freetypeharfbuzz: 0.2.6