Skip to content

Prevent multiple selectize/dynamic color brushes from being rendered in shiny #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Prevent multiple selectize/dynamic color brushes from being rendered in shiny #1936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74e1781
Close #1584: Prevent multiple selectize/dynamic color brushes from be…
cpsievert Mar 26, 2021
037c289
Update news
cpsievert Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## BUG FIXES

* Duplicate `highlight(selectize=T)` dropdowns are no longer rendered in Shiny (#1936).
* `group_by.plotly()` now properly retains crosstalk information across `{dplyr}` versions (#1920).

# 4.9.3
Expand Down
2 changes: 1 addition & 1 deletion R/utils.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ supply_highlight_attrs <- function(p) {

# include one selectize dropdown per "valid" SharedData layer
if (isTRUE(p$x$highlight$selectize)) {
p$x$selectize[[new_id()]] <- list(
p$x$selectize[[i]] <- list(
items = data.frame(value = k, label = k), group = i
)
}
Expand Down
2 changes: 1 addition & 1 deletion inst/htmlwidgets/plotly.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ HTMLWidgets.widget({
});

// inject a "control panel" holding selectize/dynamic color widget(s)
if (x.selectize || x.highlight.dynamic && !instance.plotly) {
if ((x.selectize || x.highlight.dynamic) && !instance.plotly) {
var flex = document.createElement("div");
flex.class = "plotly-crosstalk-control-panel";
flex.style = "display: flex; flex-wrap: wrap";
Expand Down