selectdirection PR review edits

Author: alexcjohnson

src/components/fx/layout_defaults.js

@@ -16,8 +16,8 @@ module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) {
         return Lib.coerce(layoutIn, layoutOut, layoutAttributes, attr, dflt);
     }
 
-    coerce('dragmode');
-    coerce('selectdirection');
+    var dragMode = coerce('dragmode');
+    if(dragMode === 'select') coerce('selectdirection');
 
     var hovermodeDflt;
     if(layoutOut._has('cartesian')) {

src/plots/cartesian/select.js

@@ -192,8 +192,6 @@ function prepSelect(e, startX, startY, dragOptions, mode) {
         }
     }
 
-    var direction = fullLayout.selectdirection;
-
     dragOptions.moveFn = function(dx0, dy0) {
         x1 = Math.max(0, Math.min(pw, dx0 + x0));
         y1 = Math.max(0, Math.min(ph, dy0 + y0));
@@ -202,6 +200,7 @@ function prepSelect(e, startX, startY, dragOptions, mode) {
             dy = Math.abs(y1 - y0);
 
         if(mode === 'select') {
+            var direction = fullLayout.selectdirection;
 
             if(fullLayout.selectdirection === 'any') {
                 if(dy < Math.min(dx * 0.6, MINSELECT)) direction = 'h';

test/jasmine/tests/shapes_test.js

@@ -1026,7 +1026,7 @@ describe('A fixed size shape', function() {
 
     var shapeAndResizeTypes = combinations(shapeTypes, resizeTypes);
     shapeAndResizeTypes.forEach(function(testCase) {
-        describe('of type ' + testCase.type + ' can be ' + testCase.resizeDisplayName, function() {
+        describe('@flaky of type ' + testCase.type + ' can be ' + testCase.resizeDisplayName, function() {
             resizeDirections.forEach(function(direction) {
                 it('over direction ' + direction, function(done) {
                     layout.shapes[0].type = testCase.type;