Skip to content

sunburst & treemap root color attribute #5232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 3, 2020
Merged

sunburst & treemap root color attribute #5232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ccebbb
sunburst & treemap root color attribute
thierryVergult Oct 24, 2020
12cd7e6
fix lint remark
thierryVergult Oct 24, 2020
53f3712
editType calc & default no coloring
thierryVergult Oct 25, 2020
2f07963
set edittype to calc, and exclude colorscale
thierryVergult Oct 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/traces/sunburst/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,5 +215,19 @@ module.exports = {
},
sort: pieAttrs.sort,

root: {
color: {
valType: 'color',
editType: 'calc',
role: 'style',
dflt: 'rgba(0,0,0,0)',
description: [
'sets the color of the root node for a sunburst or a treemap trace.',
'this has no effect when a colorscale is used to set the markers.'
].join(' ')
},
editType: 'calc'
},

domain: domainAttrs({name: 'sunburst', trace: true, editType: 'calc'})
};
4 changes: 2 additions & 2 deletions src/traces/sunburst/calc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,8 +276,8 @@ exports._runCrossTraceCalc = function(desiredType, gd) {
dfltColorCount++;
}
} else {
// root gets no coloring by default
cdi.color = 'rgba(0,0,0,0)';
// set root color. no coloring by default.
cdi.color = cdi.trace.root.color;
}
}
}
Expand Down
2 changes: 2 additions & 0 deletions src/traces/sunburst/defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout

coerce('rotation');

coerce('root.color');

handleDomainDefaults(traceOut, layout, coerce);

// do not support transforms for now
Expand Down
1 change: 1 addition & 0 deletions src/traces/treemap/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@ module.exports = {
].join(' ')
},
sort: pieAttrs.sort,
root: sunburstAttrs.root,

domain: domainAttrs({name: 'treemap', trace: true, editType: 'calc'}),
};
2 changes: 2 additions & 0 deletions src/traces/treemap/defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout

coerce('sort');

coerce('root.color');

handleDomainDefaults(traceOut, layout, coerce);

// do not support transforms for now
Expand Down