fix(question): empty name section unavailable

btry · btry · commit 356a4e184549 · 2022-01-31T09:09:32.000+01:00
should not happen, but safer
diff --git a/inc/question.class.php b/inc/question.class.php
@@ -809,7 +809,7 @@ public function showForm($ID, $options = []) {
       $section->getFromDB($this->fields['plugin_formcreator_sections_id']);
       $sections = [];
       foreach ((new PluginFormcreatorSection())->getSectionsFromForm($section->fields[PluginFormcreatorForm::getForeignKeyField()]) as $section) {
-         $sections[$section->getID()] = $section->getField('name');
+         $sections[$section->getID()] = $section->fields['name'] == '' ? '(' . $section->getID() . ')' : $section->fields['name'];
       }
       $currentSectionId = ($this->fields['plugin_formcreator_sections_id'])
                         ? $this->fields['plugin_formcreator_sections_id']

Original file line number	Diff line number	Diff line change
`@@ -809,7 +809,7 @@ public function showForm($ID, $options = []) {`
`809`	`809`	`$section->getFromDB($this->fields['plugin_formcreator_sections_id']);`
`810`	`810`	`$sections = [];`
`811`	`811`	`foreach ((new PluginFormcreatorSection())->getSectionsFromForm($section->fields[PluginFormcreatorForm::getForeignKeyField()]) as $section) {`
`812`		`- $sections[$section->getID()] = $section->getField('name');`
	`812`	`+ $sections[$section->getID()] = $section->fields['name'] == '' ? '(' . $section->getID() . ')' : $section->fields['name'];`
`813`	`813`	`}`
`814`	`814`	`$currentSectionId = ($this->fields['plugin_formcreator_sections_id'])`
`815`	`815`	`? $this->fields['plugin_formcreator_sections_id']`