Minor fixes for SelectPanel
#2325
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ffe6c0e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
Contributor
Author
|
Closing this for now since it's minor changes and will conflict with #2338. We can revisit later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a few minor fixes for the
SelectPanelcomponent:headerandfooterelements. These elements will now get theHeaderAsNonLandmarkandFooterAsNonLandmarkroles, meaning that they are semantically the header and footer of the dialog without being the header and footer of the entire page.aria-modal="true"to theSelectPaneldialog. When open, the dialog is the only thing on the page that can be interacted with. Clicking outside causes the dialog to close. Thus, it is amodal.SelectPanelfooter padding consistent with the header padding. This not only looks better (items align to a grid), it also saves a tiny bit of vertical space.Screenshots
Before
After
Merge checklist