Skip to content

Conversation

@SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Nov 10, 2022

Remove the broken process metrics collection. This is better scoped for other exporters. Keep only metrics provided by systemd itself.

Signed-off-by: SuperQ [email protected]

@SuperQ SuperQ requested review from povilasv and sysadmind November 10, 2022 15:10
@SuperQ SuperQ force-pushed the superq/remove_broken_process_metrics branch from b2b8e61 to 24a6273 Compare November 10, 2022 15:13
Copy link

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Remove the broken process metrics collection. This is better scoped for
other exporters. Keep only metrics provided by systemd itself.

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ force-pushed the superq/remove_broken_process_metrics branch from 24a6273 to f3e97be Compare November 10, 2022 15:28
@SuperQ SuperQ merged commit 627dc49 into main Dec 12, 2022
@SuperQ SuperQ deleted the superq/remove_broken_process_metrics branch December 12, 2022 08:56
SuperQ added a commit that referenced this pull request Oct 30, 2023
* [CHANGE] Remove broken metrics collection #68
* [CHANGE] Remove use of cgroups #105
* [FEATURE] Add unit timestamp metrics #58

Build updates:
* Simplify build with CircleCI orb.
* Upgrade to Go 1.21.
* Switch form codespell to misspell linter.
* Enable revive linter.
* Removed unused func param.
* Remove unnecessary promu build flags.
* Move errcheck excludes inline.

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ mentioned this pull request Oct 30, 2023
SuperQ added a commit that referenced this pull request Oct 30, 2023
* [CHANGE] Remove broken metrics collection #68
* [CHANGE] Remove use of cgroups #105
* [FEATURE] Add unit timestamp metrics #58

Build updates:
* Simplify build with CircleCI orb.
* Upgrade to Go 1.21.
* Switch form codespell to misspell linter.
* Enable revive linter.
* Removed unused func param.
* Remove unnecessary promu build flags.
* Move errcheck excludes inline.

Signed-off-by: SuperQ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants