examples: Follow best practices and established naming conventions

lilic · lilic · commit b99524cb57f8 · 2024-10-15T14:16:39.000+02:00
This is a nitpick but from my experience and understanding the best
practice for label key naming is to use one word, otherwise using an
underscore. Since this is an example users tend to copy, I think
correcting it might be a good idea.
diff --git a/examples/customlabels/main.go b/examples/customlabels/main.go
@@ -33,7 +33,7 @@ func main() {
 
 	// Create a new registry.
 	reg := prometheus.NewRegistry()
-	prometheus.WrapRegistererWith(prometheus.Labels{"serviceName": "my-service-name"}, reg).MustRegister(
+	prometheus.WrapRegistererWith(prometheus.Labels{"service": "my-service-name"}, reg).MustRegister(
 		collectors.NewGoCollector(),
 		collectors.NewProcessCollector(collectors.ProcessCollectorOpts{}),
 	)

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ func main() {`
`33`	`33`
`34`	`34`	`// Create a new registry.`
`35`	`35`	`reg := prometheus.NewRegistry()`
`36`		`- prometheus.WrapRegistererWith(prometheus.Labels{"serviceName": "my-service-name"}, reg).MustRegister(`
	`36`	`+ prometheus.WrapRegistererWith(prometheus.Labels{"service": "my-service-name"}, reg).MustRegister(`
`37`	`37`	`collectors.NewGoCollector(),`
`38`	`38`	`collectors.NewProcessCollector(collectors.ProcessCollectorOpts{}),`
`39`	`39`	`)`