fix: proper relative path to protobufjs in cli #1753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://docs.npmjs.com/cli/v8/configuring-npm/package-json#local-paths the local path should be `file:..` instead of `file://..`. The later version copies whole top-level file-system in a macOS and with a recent version of npm (8.12.2) and results in a `MODULE_NOT_FOUND` error.
bcoe
approved these changes
Jul 5, 2022
|
Going to merge this as soon as I figure out the CI problem (doing it now). |
alexander-fenster
changed the title
This was referenced Jul 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://docs.npmjs.com/cli/v8/configuring-npm/package-json#local-paths the local path should be
file:..instead offile://...The later version copies whole top-level file-system on a macOS and with a recent version of npm (8.12.2). As a result , it errors with message
Cannot find module 'protobufjs'