Cast GetCachedTID() to unsigned to prevent left-shifting a negative number.

protobuf-github-bot · copybara-github · commit 3e935cfe8827 · 2025-06-27T10:13:10.000-07:00
PiperOrigin-RevId: 776628229
diff --git a/src/google/protobuf/arenaz_sampler.cc b/src/google/protobuf/arenaz_sampler.cc
@@ -110,7 +110,7 @@ void RecordAllocateSlow(ThreadSafeArenaStats* info, size_t used,
   if (info->max_block_size.load(std::memory_order_relaxed) < allocated) {
     info->max_block_size.store(allocated, std::memory_order_relaxed);
   }
-  const uint64_t tid = 1ULL << (GetCachedTID() % 63);
+  const uint64_t tid = 1ULL << (static_cast<uint64_t>(GetCachedTID()) % 63);
   info->thread_ids.fetch_or(tid, std::memory_order_relaxed);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ void RecordAllocateSlow(ThreadSafeArenaStats* info, size_t used,`
`110`	`110`	`if (info->max_block_size.load(std::memory_order_relaxed) < allocated) {`
`111`	`111`	`info->max_block_size.store(allocated, std::memory_order_relaxed);`
`112`	`112`	`}`
`113`		`- const uint64_t tid = 1ULL << (GetCachedTID() % 63);`
	`113`	`+ const uint64_t tid = 1ULL << (static_cast<uint64_t>(GetCachedTID()) % 63);`
`114`	`114`	`info->thread_ids.fetch_or(tid, std::memory_order_relaxed);`
`115`	`115`	`}`
`116`	`116`