Remove redundant instances of 'internal' access level

Author: Daniel Browne

Sources/Extensions/PusherWebsocketDelegate.swift

@@ -117,7 +117,7 @@ extension PusherConnection: WebSocketConnectionDelegate {
      `PusherChannelsProtocolCloseCode.ReconnectionStrategy`.
      - Parameter closeCode: The closure code received by the WebSocket connection.
      */
-    internal func attemptReconnect(closeCode: NWProtocolWebSocket.CloseCode = .protocolCode(.normalClosure)) {
+    func attemptReconnect(closeCode: NWProtocolWebSocket.CloseCode = .protocolCode(.normalClosure)) {
         guard connectionState != .connected else {
             return
         }
@@ -161,7 +161,7 @@ extension PusherConnection: WebSocketConnectionDelegate {
     /// Returns a `TimeInterval` appropriate for a reconnection attempt after some delay.
     /// - Parameter strategy: The reconnection strategy for the reconnection attempt.
     /// - Returns: An appropriate `TimeInterval`. (0.0 if `strategy == .reconnectImmediately`).
-    internal func reconnectionAttemptTimeInterval(strategy: PusherChannelsProtocolCloseCode.ReconnectionStrategy) -> TimeInterval {
+    func reconnectionAttemptTimeInterval(strategy: PusherChannelsProtocolCloseCode.ReconnectionStrategy) -> TimeInterval {
         if case .reconnectImmediately = strategy {
             return 0.0
         }
@@ -174,7 +174,7 @@ extension PusherConnection: WebSocketConnectionDelegate {
 
     /// Logs the websocket reconnection attempt.
     /// - Parameter strategy: The reconnection strategy for the reconnection attempt.
-    internal func logReconnectionAttempt(strategy: PusherChannelsProtocolCloseCode.ReconnectionStrategy) {
+    func logReconnectionAttempt(strategy: PusherChannelsProtocolCloseCode.ReconnectionStrategy) {
 
         var context = "(attempt \(reconnectAttempts + 1))"
         var loggingEvent = PusherLogger.LoggingEvent.attemptReconnectionImmediately
@@ -197,7 +197,7 @@ extension PusherConnection: WebSocketConnectionDelegate {
     /// - Parameters:
     ///   - closeCode: The closure code for the websocket connection.
     ///   - reason: Optional further information on the connection closure.
-    internal func logDisconnection(closeCode: NWProtocolWebSocket.CloseCode, reason: Data?) {
+    func logDisconnection(closeCode: NWProtocolWebSocket.CloseCode, reason: Data?) {
         var rawCode: UInt16!
         switch closeCode {
         case .protocolCode(let definedCode):

Sources/Helpers/PusherLogger.swift

@@ -1,17 +1,17 @@
 import Foundation
 
 /// Used for logging events for informational purposes
-internal class PusherLogger {
+class PusherLogger {
 
     // MARK: - Enum definitions
 
-    internal enum LoggingEvent: String {
+    enum LoggingEvent: String {
 
         // Channels
 
         // swiftlint:disable:next identifier_name
         case presenceChannelSubscriptionAttemptWithoutChannelData =
-        "Attempting to subscribe to presence channel but no channelData value provided"
+                "Attempting to subscribe to presence channel but no channelData value provided"
         case subscriptionSucceededNoDataInPayload = "Subscription succeeded event received without data key in payload"
         case unableToSubscribeToChannel = "Unable to subscribe to channel:"
         case unableToAddMemberToChannel = "Unable to add member to channel"
@@ -61,52 +61,52 @@ internal class PusherLogger {
         case unableToHandleIncomingMessage = "Unable to handle incoming Websocket message"
     }
 
-    internal enum LoggingLevel: String {
+    enum LoggingLevel: String {
         case debug      = "[PUSHER DEBUG]"
         case info       = "[PUSHER INFO]"
         case warning    = "[PUSHER WARNING]"
         case error      = "[PUSHER ERROR]"
     }
 
-    internal static let shared = PusherLogger()
+    static let shared = PusherLogger()
 
-    internal weak var delegate: PusherDelegate?
+    weak var delegate: PusherDelegate?
 
     // MARK: - Event logging
 
     /// Logs a debug message relating to a particular event of interest.
     /// - Parameters:
     ///   - event: A particular `LoggingEvent` of interest.
     ///   - context: Additional context for the message.
-    internal func debug(for event: LoggingEvent,
-                        context: CustomStringConvertible? = nil) {
+    func debug(for event: LoggingEvent,
+               context: CustomStringConvertible? = nil) {
         message(for: event, level: .debug, context: context)
     }
 
     /// Logs an informational message relating to a particular event of interest.
     /// - Parameters:
     ///   - event: A particular `LoggingEvent` of interest.
     ///   - context: Additional context for the message.
-    internal func info(for event: LoggingEvent,
-                       context: CustomStringConvertible? = nil) {
+    func info(for event: LoggingEvent,
+              context: CustomStringConvertible? = nil) {
         message(for: event, level: .info, context: context)
     }
 
     /// Logs a warning message relating to a particular event of interest.
     /// - Parameters:
     ///   - event: A particular `LoggingEvent` of interest.
     ///   - context: Additional context for the message.
-    internal func warning(for event: LoggingEvent,
-                          context: CustomStringConvertible? = nil) {
+    func warning(for event: LoggingEvent,
+                 context: CustomStringConvertible? = nil) {
         message(for: event, level: .warning, context: context)
     }
 
     /// Logs an error message relating to a particular event of interest.
     /// - Parameters:
     ///   - event: A particular `LoggingEvent` of interest.
     ///   - context: Additional context for the message.
-    internal func error(for event: LoggingEvent,
-                        context: CustomStringConvertible? = nil) {
+    func error(for event: LoggingEvent,
+               context: CustomStringConvertible? = nil) {
         message(for: event, level: .error, context: context)
     }
 

Sources/Helpers/PusherParser.swift

@@ -1,6 +1,6 @@
 import Foundation
 
-internal struct PusherParser {
+struct PusherParser {
 
     /**
      Parse a string to extract Pusher event information from it

Sources/Models/PusherChannelsProtocolCloseCode.swift

@@ -7,14 +7,14 @@ import Foundation
 /// These closure codes fall in the 4000 - 4999 range, i.e. the `privateCode` case of `NWProtocolWebSocket.CloseCode`.
 ///
 /// Reference: https://pusher.com/docs/channels/library_auth_reference/pusher-websockets-protocol#error-codes
-internal enum PusherChannelsProtocolCloseCode: UInt16 {
+enum PusherChannelsProtocolCloseCode: UInt16 {
 
     // MARK: - Pusher Channels Protocol reconnection strategies
 
     /// Describes the reconnection strategy for a given `PusherChannelsProtocolCloseCode`.
     ///
     /// Reference: https://pusher.com/docs/channels/library_auth_reference/pusher-websockets-protocol#connection-closure
-    internal enum ReconnectionStrategy: UInt16 {
+    enum ReconnectionStrategy: UInt16 {
 
         /// Indicates an error resulting in the connection being closed by Pusher Channels,
         /// and that attempting to reconnect using the same parameters will not succeed.