Fix Dataset.map to handle non-DataArray outputs #10839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After PR pydata#10602, Dataset.map started failing when functions returned non-DataArray values (e.g., scalars), raising AttributeError when trying to access .coords on the returned values. This restores backward compatibility by converting non-DataArray outputs to DataArrays, which was the behavior before the regression. Fixes pydata#10835 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
shoyer
approved these changes
Oct 10, 2025
keewis
reviewed
Oct 10, 2025
Comment on lines
+6934
to
+6938
| # Convert non-DataArray values to DataArrays | ||
| variables = { | ||
| k: v if isinstance(v, DataArray) else DataArray(v) | ||
| for k, v in variables.items() | ||
| } |
Collaborator
There was a problem hiding this comment.
would it make sense to wrap the maybe_wrap_array call above with a ensure_dataarray call (that would be a new function)? That way we don't have to iterate over the variables again.
Collaborator
Author
There was a problem hiding this comment.
v reasonable; I'll merge this but agree that would be a smidge faster...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10835
Summary
After PR #10602,
Dataset.mapstarted failing when functions returned non-DataArray values (e.g., scalars), raisingAttributeError: 'int' object has no attribute 'coords'when trying to access.coordson the returned values.This PR restores backward compatibility by converting non-DataArray outputs to DataArrays before accessing their
.coordsattribute.Changes
Dataset.mapto check if returned values are DataArrays and convert them if notTest plan
test_map_non_dataarray_outputscovering scalar outputs, numpy arrays, and mixed casesDataset.maptests passtest_dataset.pypass (495 passed)🤖 Generated with Claude Code