From b35e9ce207e7d9c38128279d4a9954274ae2ec17 Mon Sep 17 00:00:00 2001 From: Illviljan <14371165+Illviljan@users.noreply.github.com> Date: Tue, 10 Jan 2023 23:24:17 +0100 Subject: [PATCH 1/5] PR labeler, workaround sync-labels bug --- .github/workflows/label-prs.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/label-prs.yml b/.github/workflows/label-prs.yml index ec39e68a3ff..fcfb27b4bd1 100644 --- a/.github/workflows/label-prs.yml +++ b/.github/workflows/label-prs.yml @@ -9,4 +9,6 @@ jobs: - uses: actions/labeler@main with: repo-token: "${{ secrets.GITHUB_TOKEN }}" - sync-labels: false + # Workaround for sync-labels bug: + # https://github.com/actions/labeler/issues/112 + sync-labels: "" From 8c99c3b6772492dea59f39c915509a59354033f6 Mon Sep 17 00:00:00 2001 From: Illviljan <14371165+Illviljan@users.noreply.github.com> Date: Tue, 10 Jan 2023 23:31:29 +0100 Subject: [PATCH 2/5] Update label-prs.yml --- .github/workflows/label-prs.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/label-prs.yml b/.github/workflows/label-prs.yml index fcfb27b4bd1..c2fcb9f891f 100644 --- a/.github/workflows/label-prs.yml +++ b/.github/workflows/label-prs.yml @@ -10,5 +10,6 @@ jobs: with: repo-token: "${{ secrets.GITHUB_TOKEN }}" # Workaround for sync-labels bug: + # https://github.com/actions/labeler/issues/112 sync-labels: "" From 3a3fa730eb71c157337fe9a47772e473a9c2b08c Mon Sep 17 00:00:00 2001 From: Illviljan <14371165+Illviljan@users.noreply.github.com> Date: Tue, 10 Jan 2023 23:39:50 +0100 Subject: [PATCH 3/5] The bot gets it's own label then. --- .github/labeler.yml | 2 +- .github/workflows/benchmarks.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/labeler.yml b/.github/labeler.yml index 34d49ab231e..7c588063475 100644 --- a/.github/labeler.yml +++ b/.github/labeler.yml @@ -54,7 +54,7 @@ topic-indexing: - xarray/core/indexes.py - xarray/core/indexing.py -run-benchmark: +run-benchmark-bot: - asv_bench/benchmarks/* - asv_bench/benchmarks/**/* diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 5b85cfa5275..363bad5a04f 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -7,7 +7,7 @@ on: jobs: benchmark: - if: ${{ contains( github.event.pull_request.labels.*.name, 'run-benchmark') && github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch' }} + if: ${{ contains( github.event.pull_request.labels.*.name, 'run-benchmark') && github.event_name == 'pull_request' || contains( github.event.pull_request.labels.*.name, 'run-benchmark-bot') && github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch' }} name: Linux runs-on: ubuntu-20.04 env: From 303e08606f8b2da72b70fbc0bfa8ee464832ab08 Mon Sep 17 00:00:00 2001 From: Illviljan <14371165+Illviljan@users.noreply.github.com> Date: Tue, 10 Jan 2023 23:52:05 +0100 Subject: [PATCH 4/5] Update label-prs.yml --- .github/workflows/label-prs.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/label-prs.yml b/.github/workflows/label-prs.yml index c2fcb9f891f..fcfb27b4bd1 100644 --- a/.github/workflows/label-prs.yml +++ b/.github/workflows/label-prs.yml @@ -10,6 +10,5 @@ jobs: with: repo-token: "${{ secrets.GITHUB_TOKEN }}" # Workaround for sync-labels bug: - # https://github.com/actions/labeler/issues/112 sync-labels: "" From 8d1b2d0ac73fe46630dc92f3a4543264d874eab0 Mon Sep 17 00:00:00 2001 From: Illviljan <14371165+Illviljan@users.noreply.github.com> Date: Tue, 10 Jan 2023 23:58:10 +0100 Subject: [PATCH 5/5] bot get's to change topic-performance, we humans get run-benchmarks --- .github/labeler.yml | 4 ---- .github/workflows/benchmarks.yml | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/labeler.yml b/.github/labeler.yml index 7c588063475..d866a7342fe 100644 --- a/.github/labeler.yml +++ b/.github/labeler.yml @@ -54,10 +54,6 @@ topic-indexing: - xarray/core/indexes.py - xarray/core/indexing.py -run-benchmark-bot: - - asv_bench/benchmarks/* - - asv_bench/benchmarks/**/* - topic-performance: - asv_bench/benchmarks/* - asv_bench/benchmarks/**/* diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 363bad5a04f..07fe7ef6256 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -7,7 +7,7 @@ on: jobs: benchmark: - if: ${{ contains( github.event.pull_request.labels.*.name, 'run-benchmark') && github.event_name == 'pull_request' || contains( github.event.pull_request.labels.*.name, 'run-benchmark-bot') && github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch' }} + if: ${{ contains( github.event.pull_request.labels.*.name, 'run-benchmark') && github.event_name == 'pull_request' || contains( github.event.pull_request.labels.*.name, 'topic-performance') && github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch' }} name: Linux runs-on: ubuntu-20.04 env: