style: Cleanup subtensor make_node

Author: aseyboldt

pytensor/tensor/subtensor.py

@@ -732,46 +732,27 @@ def make_node(self, x, *inputs):
                     f"Incompatible types for Subtensor template. Expected {input.type}, got {expected_type}."
                 )
 
-        padded = list(self.idx_list) + [slice(None, None, None)] * (x.type.ndim - len(idx_list))
+        padded = list(self.idx_list) + [slice(None, None, None)] * (
+            x.type.ndim - len(idx_list)
+        )
 
         out_shape = []
 
-        def extract_const(value):
-            if value is None:
-                return value, True
-            try:
-                value = get_underlying_scalar_constant_value(value)
-                return value, True
-            except NotScalarConstantError:
-                return value, False
-
         for the_slice, length in zip(padded, x.type.shape):
             if isinstance(the_slice, slice):
                 if length is None:
                     out_shape.append(None)
                     continue
 
-                start = the_slice.start
-                stop = the_slice.stop
-                step = the_slice.step
-
-                is_slice_const = True
-
-                start, is_const = extract_const(start)
-                is_slice_const = is_slice_const and is_const
-
-                stop, is_const = extract_const(stop)
-                is_slice_const = is_slice_const and is_const
-
-                step, is_const = extract_const(step)
-                is_slice_const = is_slice_const and is_const
-
-                if not is_slice_const:
+                try:
+                    start = get_underlying_scalar_constant_value(the_slice.start)
+                    stop = get_underlying_scalar_constant_value(the_slice.stop)
+                    step = get_underlying_scalar_constant_value(the_slice.step)
+                except NotScalarConstantError:
                     out_shape.append(None)
-                    continue
-
-                slice_length = len(range(*slice(start, stop, step).indices(length)))
-                out_shape.append(slice_length)
+                else:
+                    slice_length = len(range(*slice(start, stop, step).indices(length)))
+                    out_shape.append(slice_length)
 
         return Apply(
             self,