Skip to content

Commit a96e5a1

Browse files
committed
Update OpFromGraph TODO
1 parent dd9f9d1 commit a96e5a1

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

pytensor/compile/builders.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -159,16 +159,9 @@ class OpFromGraph(Op, HasInnerGraph):
159159
Currently does not support ``updates`` or ``givens`` argument.
160160
161161
.. TODO:
162-
- examples for a multi-layer mlp. where?
163-
- __hash__, __eq__ otherwise won't merge, try
164-
is_same_graph_with_merge(op1.local_outputs, op2,
165-
local_outputs)
166-
- c_code() to remove the double overhead?
167-
- grad() make it support DisconnectedType and the new interface
168-
- add support for NullType and DisconnectedType when R_op supports them
169-
- check how it works with updates.
162+
- Allow / test merging of OpFromGraph nodes
163+
- Add support for NullType and DisconnectedType when R_op supports them
170164
- Add support to pickle this Op.
171-
- Add support/test with random generator
172165
- Add optimization to removing unused inputs/outputs
173166
- Add optimization to work inplace on inputs when not inline
174167

0 commit comments

Comments
 (0)