move server_hostname to be local in tls client. (#1978)

Author: janiversen

pymodbus/client/base.py

@@ -303,11 +303,8 @@ class _params:
         retry_on_empty: bool | None = None
         broadcast_enable: bool | None = None
         reconnect_delay: int | None = None
-
         source_address: tuple[str, int] | None = None
 
-        server_hostname: str | None = None
-
     def __init__(
         self,
         framer: Framer,

pymodbus/client/tls.py

@@ -158,7 +158,7 @@ def __init__(
         self.sslctx = CommParams.generate_ssl(
             False, certfile, keyfile, password, sslctx=sslctx
         )
-        self.params.server_hostname = server_hostname
+        self.server_hostname = server_hostname
 
     @property
     def connected(self) -> bool:
@@ -174,7 +174,7 @@ def connect(self):
             if self.params.source_address:
                 sock.bind(self.params.source_address)
             self.socket = self.sslctx.wrap_socket(
-                sock, server_side=False, server_hostname=self.comm_params.host
+                sock, server_side=False, server_hostname=self.server_hostname
             )
             self.socket.settimeout(self.comm_params.timeout_connect)
             self.socket.connect((self.comm_params.host, self.comm_params.port))