Eliminate final (!) implicit optional

Author: alexrudd2

pymodbus/transport/transport.py

@@ -156,8 +156,8 @@ def __init__(
         self.is_server = is_server
         self.is_closing = False
 
-        self.transport: asyncio.BaseTransport = None
-        self.loop: asyncio.AbstractEventLoop = None
+        self.transport: asyncio.BaseTransport | None = None
+        self.loop: asyncio.AbstractEventLoop
         self.recv_buffer: bytes = b""
         self.call_create: Callable[[], Coroutine[Any, Any, Any]] = lambda: None
         if self.is_server:
@@ -240,8 +240,7 @@ def init_setup_connect_listen(self, host: str, port: int) -> None:
     async def transport_connect(self) -> bool:
         """Handle generic connect and call on to specific transport connect."""
         Log.debug("Connecting {}", self.comm_params.comm_name)
-        if not self.loop:
-            self.loop = asyncio.get_running_loop()
+        self.loop = asyncio.get_running_loop()
         self.is_closing = False
         try:
             self.transport, _protocol = await asyncio.wait_for(
@@ -260,12 +259,11 @@ async def transport_connect(self) -> bool:
     async def transport_listen(self) -> bool:
         """Handle generic listen and call on to specific transport listen."""
         Log.debug("Awaiting connections {}", self.comm_params.comm_name)
-        if not self.loop:
-            self.loop = asyncio.get_running_loop()
+        self.loop = asyncio.get_running_loop()
         self.is_closing = False
         try:
             self.transport = await self.call_create()
-            if isinstance(self.transport, tuple):
+            if self.transport and isinstance(self.transport, tuple):
                 self.transport = self.transport[0]
         except OSError as exc:
             Log.warning("Failed to start server {}", exc)
@@ -395,11 +393,11 @@ def transport_send(self, data: bytes, addr: tuple | None = None) -> None:
             self.sent_buffer += data
         if self.comm_params.comm_type == CommType.UDP:
             if addr:
-                self.transport.sendto(data, addr=addr)  # type: ignore[attr-defined]
+                self.transport.sendto(data, addr=addr)  # type: ignore[union-attr]
             else:
-                self.transport.sendto(data)  # type: ignore[attr-defined]
+                self.transport.sendto(data)  # type: ignore[union-attr]
         else:
-            self.transport.write(data)  # type: ignore[attr-defined]
+            self.transport.write(data)  # type: ignore[union-attr]
 
     def transport_close(self, intern: bool = False, reconnect: bool = False) -> None:
         """Close connection.

pyproject.toml

@@ -187,7 +187,7 @@ overgeneral-exceptions = "builtins.Exception"
 bad-functions = "map,input"
 
 [tool.mypy]
-strict_optional = false
+strict_optional = true
 show_error_codes = true
 local_partial_types = true
 strict_equality = true