Drop setup.py install support
#11874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
force-pushed
the
drop-setup-py-install-sbi
branch
from
cbed7f9 to
7e4c4fa
Compare
sbidoul
changed the title
sbidoul
force-pushed
the
drop-setup-py-install-sbi
branch
from
7e4c4fa to
603b31d
Compare
sbidoul
changed the title
setup.py install support
sbidoul
added
project: setuptools
github-actions
bot
added
the
needs rebase or merge
sbidoul
force-pushed
the
drop-setup-py-install-sbi
branch
from
603b31d to
10a87ad
Compare
sbidoul
changed the title
setup.py install supportsetup.py install support
sbidoul
force-pushed
the
drop-setup-py-install-sbi
branch
from
af352e2 to
1fcb1c7
Compare
sbidoul
force-pushed
the
drop-setup-py-install-sbi
branch
from
1fcb1c7 to
e0e68d2
Compare
github-actions
bot
added
the
needs rebase or merge
sbidoul
force-pushed
the
drop-setup-py-install-sbi
branch
from
491a8a0 to
334362f
Compare
Member
Author
|
🟢 |
uranusjr
reviewed
Mar 28, 2023
Comment on lines
-763
to
+760
| global_options=global_options, | ||
| global_options=global_options if global_options is not None else [], |
Member
Author
There was a problem hiding this comment.
Cosmetics only. Since the variable is not used anywhere else, I figured I'd inline it.
uranusjr
approved these changes
Mar 28, 2023
Member
Author
|
If there are no objections, I plan to merge this on Friday or Saturday so it lands on time for 23.1. |
Closed
1 task
This test depended on setup.py install, and tbh, I don't see a good reason to attempt an install when testing the requirements file parser.
It relied on a function that does not exist anymore.
sbidoul
force-pushed
the
drop-setup-py-install-sbi
branch
from
334362f to
849dcbd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8368
closes #8102