Fix broken approx when mixing numpy booleans and booleans
#13338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
nicoddemus
requested changes
Apr 1, 2025
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks @BahramF73 for the PR!
Can you please add a test to ensure the code works as intended and prevent future regressions? Thanks!
Co-authored-by: Bruno Oliveira <[email protected]>
for more information, see https://pre-commit.ci
Contributor
Author
|
Hi @nicoddemus, I added some tests. Please check it! |
for more information, see https://pre-commit.ci
nicoddemus
approved these changes
Apr 1, 2025
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks @BahramF73, we appreciate it!
I will squash/merge in the next few days.
Contributor
Author
You're welcome! Glad to contribute. |
Pierre-Sassoulas
changed the title
approx when mixing numpy booleans and booleans
The-Compiler
reviewed
Apr 1, 2025
The-Compiler
approved these changes
Apr 1, 2025
Backport to 8.3.x: 💚 backport PR created✅ Backport PR branch: Backported as #13342 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
Fix #13047 --------- Co-authored-by: Bruno Oliveira <[email protected]> (cherry picked from commit 0c45497)
6 tasks
nicoddemus
pushed a commit
that referenced
this pull request
Apr 2, 2025
Fix #13047 --------- Co-authored-by: Bruno Oliveira <[email protected]> (cherry picked from commit 0c45497) Co-authored-by: Bahram Farahmand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue in equality checks where
boolandnumpy.bool_types were not handled consistently.This ensures proper handling of native and numpy boolean types. See #13047.
Fix #13047
Checklist
closes #13047to link this PR to the issue.13047.bugfix.rst.AUTHORSin alphabetical order.