Use HAVE_PTHREAD_STUBS instead

colesbury · colesbury · commit fe38ff959c78 · 2023-11-09T13:54:18.000-05:00
diff --git a/Include/pyport.h b/Include/pyport.h
@@ -470,13 +470,6 @@ extern "C" {
 #  define WITH_THREAD
 #endif
 
-/* Some WebAssembly platforms do not provide a working pthread implementation.
- * Thread support is stubbed and any attempt to create a new thread fails.
- */
-#if !defined(__wasi__) && (!defined(__EMSCRIPTEN__) || defined(__EMSCRIPTEN_PTHREADS__))
-#  define Py_CAN_START_THREADS 1
-#endif
-
 #ifdef WITH_THREAD
 #  ifdef Py_BUILD_CORE
 #    ifdef HAVE_THREAD_LOCAL
diff --git a/Modules/_testinternalcapi/test_critical_sections.c b/Modules/_testinternalcapi/test_critical_sections.c
@@ -170,7 +170,7 @@ thread_critical_sections(void *arg)
     }
 }
 
-#ifdef Py_CAN_START_THREADS
+#ifndef HAVE_PTHREAD_STUBS
 static PyObject *
 test_critical_sections_threads(PyObject *self, PyObject *Py_UNUSED(args))
 {
@@ -201,7 +201,7 @@ static PyMethodDef test_methods[] = {
     {"test_critical_sections", test_critical_sections, METH_NOARGS},
     {"test_critical_sections_nest", test_critical_sections_nest, METH_NOARGS},
     {"test_critical_sections_suspend", test_critical_sections_suspend, METH_NOARGS},
-#ifdef Py_CAN_START_THREADS
+#ifndef HAVE_PTHREAD_STUBS
     {"test_critical_sections_threads", test_critical_sections_threads, METH_NOARGS},
 #endif
     {NULL, NULL} /* sentinel */

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ thread_critical_sections(void *arg)`
`170`	`170`	`}`
`171`	`171`	`}`
`172`	`172`
`173`		`-#ifdef Py_CAN_START_THREADS`
	`173`	`+#ifndef HAVE_PTHREAD_STUBS`
`174`	`174`	`static PyObject *`
`175`	`175`	`test_critical_sections_threads(PyObject self, PyObject Py_UNUSED(args))`
`176`	`176`	`{`
`@@ -201,7 +201,7 @@ static PyMethodDef test_methods[] = {`
`201`	`201`	`{"test_critical_sections", test_critical_sections, METH_NOARGS},`
`202`	`202`	`{"test_critical_sections_nest", test_critical_sections_nest, METH_NOARGS},`
`203`	`203`	`{"test_critical_sections_suspend", test_critical_sections_suspend, METH_NOARGS},`
`204`		`-#ifdef Py_CAN_START_THREADS`
	`204`	`+#ifndef HAVE_PTHREAD_STUBS`
`205`	`205`	`{"test_critical_sections_threads", test_critical_sections_threads, METH_NOARGS},`
`206`	`206`	`#endif`
`207`	`207`	`{NULL, NULL} /* sentinel */`