Skip to content

Conversation

@rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Nov 6, 2021

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are required.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

Copy link
Member

@tim-one tim-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, thanks! This is exactly the kind of thing I was looking for.

The issues are essentially identical in the workalike multiprocessing.Process(), which is the other place I very frequently see this come up. So please fiddle those docs too.

In other contexts, I see the docs generally don't even mention the type. For example, for the initargs= argument to multiprocessing.Pool(), they say:

initializer(*initargs)

will be called. So they're effectively promising that any object whatsover is fine just so long as *initargs "works".

Too obvious to mention, so I will 😉:

  • At least one doc example for each affected function should be changed (or added) to illustrate the use of a list.

  • Tests should be added to verify that lists work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes docs Documentation in the Doc dir needs backport to 3.10 only security fixes skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants