gh-92994: Clarify importlib "check" example #92995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
commented
May 20, 2022
slateny
reviewed
May 20, 2022
JelleZijlstra
approved these changes
May 22, 2022
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Seems like a useful addition, thanks!
JelleZijlstra
added
needs backport to 3.10
Contributor
|
Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Contributor
|
Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-93085 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 23, 2022
Fixes pythonGH-92994 (cherry picked from commit e39cd76) Co-authored-by: Shantanu <[email protected]>
|
GH-93086 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 23, 2022
Fixes pythonGH-92994 (cherry picked from commit e39cd76) Co-authored-by: Shantanu <[email protected]>
miss-islington
added a commit
that referenced
this pull request
May 23, 2022
Fixes GH-92994 (cherry picked from commit e39cd76) Co-authored-by: Shantanu <[email protected]>
miss-islington
added a commit
that referenced
this pull request
May 23, 2022
Fixes GH-92994 (cherry picked from commit e39cd76) Co-authored-by: Shantanu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.