Meta: Allow adding date to Resolution header #4061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
requested review from
AA-Turner,
CAM-Gerlach,
brettcannon,
hugovk,
ncoghlan and
warsaw
as code owners
hugovk
reviewed
Oct 16, 2024
warsaw
approved these changes
Oct 16, 2024
Member
warsaw
left a comment
warsaw
left a comment
There was a problem hiding this comment.
I like it, but I also wonder whether it's obvious that the date link is pointing to the DPO thread in the examples. Maybe it's good enough, but I also kind of liked the "Discord thread" text! Just a thought, no objections from me.
hugovk
approved these changes
Oct 16, 2024
Member
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
Thanks!
I added some extra tests in hugovk@6bc1e72 in case you want to pull it in. Or I can PR it your branch, or after this is merged?
Member
Author
|
Thanks Hugo! Feel free to push those tests onto my branch; if not I can run the right git commands in a little bit. |
Member
|
Pushed! |
Contributor
|
Thanks folks, great improvement ❤️ |
gvanrossum
pushed a commit
to gvanrossum/peps
that referenced
this pull request
Dec 10, 2024
Fixes python#4054 Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4054.
📚 Documentation preview 📚: https://pep-previews--4061.org.readthedocs.build/