doc errors and improve checks

Signed-off-by: Sagar Sumit <[email protected]>

Author: codope

src/ray/core_worker/core_worker.h

@@ -1499,6 +1499,19 @@ class CoreWorker {
       std::string *application_error);
 
   /// Put an object in the local plasma store.
+  ///
+  /// Return status semantics:
+  /// - Status::OK(): The object was created (or already existed) and bookkeeping was
+  ///   updated. Note: an internal ObjectExists from the plasma provider is treated
+  ///   as OK and does not surface here.
+  /// - Status::ObjectStoreFull(): The local plasma store is out of memory (or out of
+  ///   disk when spilling). The error message contains context and a short memory
+  ///   report.
+  /// - Status::IOError(): IPC/connection failures while talking to the plasma store
+  ///   (e.g., broken pipe/connection reset during shutdown, store not reachable).
+  ///
+  /// Call sites that run during shutdown may choose to tolerate IOError specifically,
+  /// but should treat all other statuses as real failures.
   Status PutInLocalPlasmaStore(const RayObject &object,
                                const ObjectID &object_id,
                                bool pin_object);

src/ray/core_worker/core_worker_process.cc

@@ -424,20 +424,11 @@ std::shared_ptr<CoreWorker> CoreWorkerProcessImpl::CreateCoreWorker(
       [this](const RayObject &object, const ObjectID &object_id) {
         auto core_worker = GetCoreWorker();
 
-        // Check if the core worker is shutting down before attempting plasma operations.
-        // During shutdown, the plasma store connection may already be broken, so we
-        // should avoid plasma operations entirely.
-        if (core_worker->IsShuttingDown()) {
-          RAY_LOG(INFO) << "Skipping plasma store operation for error object "
-                        << object_id << " because core worker is shutting down.";
-          return;
-        }
-
         auto status =
             core_worker->PutInLocalPlasmaStore(object, object_id, /*pin_object=*/true);
         if (!status.ok()) {
           // During shutdown, plasma store connections can be closed causing IOError.
-          // We only tolerate IOError during shutdown to avoid masking real errors.
+          // Tolerate only IOError during shutdown to avoid masking real errors.
           if (status.IsIOError() && core_worker->IsShuttingDown()) {
             // Double-check shutdown state - this handles the race where shutdown
             // began after our first check but before the plasma operation.