refactor: deprecate some api and add test case (#581)

Author: aojunhao123

.gitignore

@@ -26,6 +26,7 @@ lib
 es
 yarn.lock
 package-lock.json
+pnpm-lock.yaml
 coverage
 # umi
 .umi

src/Cascader.tsx

@@ -112,9 +112,11 @@ interface BaseCascaderProps<
   placement?: Placement;
   builtinPlacements?: BuildInPlacements;
 
-  /** @deprecated Use `onDropdownVisibleChange` instead */
+  /** @deprecated Use `onOpenChange` instead */
   onPopupVisibleChange?: (open: boolean) => void;
+  /** @deprecated Use `onOpenChange` instead */
   onDropdownVisibleChange?: (open: boolean) => void;
+  onOpenChange?: (open: boolean) => void;
 
   // Icon
   expandIcon?: React.ReactNode;
@@ -227,6 +229,7 @@ const Cascader = React.forwardRef<CascaderRef, InternalCascaderProps>((props, re
 
     onDropdownVisibleChange,
     onPopupVisibleChange,
+    onOpenChange,
 
     // Icon
     expandIcon = '>',
@@ -384,6 +387,7 @@ const Cascader = React.forwardRef<CascaderRef, InternalCascaderProps>((props, re
   const mergedPlacement = placement || popupPlacement;
 
   const onInternalDropdownVisibleChange = (nextVisible: boolean) => {
+    onOpenChange?.(nextVisible)
     onDropdownVisibleChange?.(nextVisible);
     onPopupVisibleChange?.(nextVisible);
   };

src/utils/warningPropsUtil.ts

@@ -2,11 +2,15 @@ import warning from 'rc-util/lib/warning';
 import type { DefaultOptionType, FieldNames, InternalCascaderProps } from '../Cascader';
 
 function warningProps(props: InternalCascaderProps) {
-  const { onPopupVisibleChange, popupVisible, popupClassName, popupPlacement } = props;
+  const { onPopupVisibleChange, popupVisible, popupClassName, popupPlacement, onDropdownVisibleChange } = props;
 
   warning(
     !onPopupVisibleChange,
-    '`onPopupVisibleChange` is deprecated. Please use `onDropdownVisibleChange` instead.',
+    '`onPopupVisibleChange` is deprecated. Please use `onOpenChange` instead.',
+  );
+  warning(
+    !onDropdownVisibleChange,
+    '`onDropdownVisibleChange` is deprecated. Please use `onOpenChange` instead.',
   );
   warning(popupVisible === undefined, '`popupVisible` is deprecated. Please use `open` instead.');
   warning(

tests/index.spec.tsx

@@ -514,21 +514,26 @@ describe('Cascader.Basic', () => {
     expect(wrapper.isOpen()).toBeTruthy();
   });
 
-  it('warning popupVisible & onPopupVisibleChange & popupClassName', () => {
+  it('warning popupVisible & onPopupVisibleChange & onDropdownVisibleChange & popupClassName & popupPlacement', () => {
     resetWarned();
     const errorSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
     const onPopupVisibleChange = jest.fn();
+    const onDropdownVisibleChange = jest.fn();
     const wrapper = mount(
       <Cascader
         popupVisible
         onPopupVisibleChange={onPopupVisibleChange}
+        onDropdownVisibleChange={onDropdownVisibleChange}
         popupClassName="legacy-cls"
         popupPlacement="topRight"
       />,
     );
 
     expect(errorSpy).toHaveBeenCalledWith(
-      'Warning: `onPopupVisibleChange` is deprecated. Please use `onDropdownVisibleChange` instead.',
+      'Warning: `onPopupVisibleChange` is deprecated. Please use `onOpenChange` instead.',
+    );
+    expect(errorSpy).toHaveBeenCalledWith(
+      'Warning: `onDropdownVisibleChange` is deprecated. Please use `onOpenChange` instead.',
     );
     expect(errorSpy).toHaveBeenCalledWith(
       'Warning: `popupVisible` is deprecated. Please use `open` instead.',