fix: remove useless html when gotoButton is false (#120)

fix: remove useless html when gotoButton is false

Author: 愚指导

src/Pagination.jsx

@@ -314,6 +314,14 @@ export default class Pagination extends React.Component {
             >{goButton}</span>
           );
         }
+        gotoButton = (
+          <li
+            title={props.showTitle ? `${locale.jump_to}${this.state.current}/${allPages}` : null}
+            className={`${prefixCls}-simple-pager`}
+          >
+            {gotoButton}
+          </li>
+        );
       }
       return (
         <ul className={`${prefixCls} ${prefixCls}-simple ${props.className}`} style={props.style}>
@@ -352,12 +360,7 @@ export default class Pagination extends React.Component {
           >
             {props.itemRender(nextPage, 'next', <a className={`${prefixCls}-item-link`} />)}
           </li>
-          <li
-            title={props.showTitle ? `${locale.jump_to}${this.state.current}/${allPages}` : null}
-            className={`${prefixCls}-simple-pager`}
-          >
-            {gotoButton}
-          </li>
+          {gotoButton}
         </ul>
       );
     }

tests/Pagination.spec.js

@@ -421,21 +421,12 @@ describe('simple Pagination', () => {
   const container = document.createElement('div');
   document.body.appendChild(container);
 
-  let current = 1;
-  let pageSize;
-  function onChange(page, pSize) {
-    current = page;
-    pageSize = pSize;
-  }
-
   beforeEach((done) => {
     ReactDOM.render(
       <Pagination
         simple
-        onChange={onChange}
         defaultCurrent={1}
         total={25}
-        showQuickJumper={{ goButton: <button>go</button> }}
         showTotal={(total, range) => `${range[0]} - ${range[1]} of ${total} items`}
       />,
       container,
@@ -465,6 +456,50 @@ describe('simple Pagination', () => {
     expect(prevButton.getAttribute('aria-disabled')).to.equal('true');
   });
 
+  it('no quick jump', () => {
+    const simplePagers = TestUtils.scryRenderedDOMComponentsWithClass(
+      pagination,
+      'rc-pagination-simple-pager'
+    );
+    expect(simplePagers.length).to.be(1);
+  });
+});
+
+
+describe('simple Pagination with quick jump', () => {
+  let pagination = null;
+  const container = document.createElement('div');
+  document.body.appendChild(container);
+
+  let current = 1;
+  let pageSize;
+  function onChange(page, pSize) {
+    current = page;
+    pageSize = pSize;
+  }
+
+  beforeEach((done) => {
+    ReactDOM.render(
+      <Pagination
+        simple
+        onChange={onChange}
+        defaultCurrent={1}
+        total={25}
+        showQuickJumper={{ goButton: <button>go</button> }}
+        showTotal={(total, range) => `${range[0]} - ${range[1]} of ${total} items`}
+      />,
+      container,
+      function () {
+        pagination = this;
+        done();
+      },
+    );
+  });
+
+  afterEach(() => {
+    ReactDOM.unmountComponentAtNode(container);
+  });
+
   it('should quick jump to expect page', (done) => {
     const quickJumper = TestUtils.findRenderedDOMComponentWithClass(
       pagination,