Skip to content

fix: sticky event loop by Copilot AI #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2025
Merged

fix: sticky event loop by Copilot AI #1231

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85007a4
fix: sticky event loop
zombieJ Feb 14, 2025
100d0b5
chore: back of container
zombieJ Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/stickyScrollBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ const StickyScrollBar: React.ForwardRefRenderFunction<unknown, StickyScrollBarPr
};

const checkScrollBarVisible = () => {
raf.cancel(rafRef.current);

rafRef.current = raf(() => {
if (!scrollBodyRef.current) {
return;
Expand Down Expand Up @@ -147,12 +149,27 @@ const StickyScrollBar: React.ForwardRefRenderFunction<unknown, StickyScrollBarPr
};
}, [scrollBarWidth, isActive]);

// Loop for scroll event check
React.useEffect(() => {
container.addEventListener(SCROLL_EVENT, checkScrollBarVisible, false);
if (!scrollBodyRef.current) return;

const scrollParents: HTMLElement[] = [];
let parent: HTMLElement = scrollBodyRef.current;
while (parent) {
scrollParents.push(parent);
parent = parent.parentElement;
}

scrollParents.forEach(p => p.addEventListener(SCROLL_EVENT, checkScrollBarVisible, false));
window.addEventListener(RESIZE_EVENT, checkScrollBarVisible, false);
window.addEventListener(SCROLL_EVENT, checkScrollBarVisible, false);
container.addEventListener(SCROLL_EVENT, checkScrollBarVisible, false);

return () => {
container.removeEventListener(SCROLL_EVENT, checkScrollBarVisible);
scrollParents.forEach(p => p.removeEventListener(SCROLL_EVENT, checkScrollBarVisible));
window.removeEventListener(RESIZE_EVENT, checkScrollBarVisible);
window.removeEventListener(SCROLL_EVENT, checkScrollBarVisible);
container.removeEventListener(SCROLL_EVENT, checkScrollBarVisible);
};
}, [container]);

Expand Down
Loading