Skip to content

Commit 30c01b1

Browse files
gaearonfacebook-github-bot
authored andcommitted
Move DevTools integration into its own repo
Summary: The way React DevTools integration was set up in RN was not entirely supported by the React team, and we had to disable it in c3b25c9059f57ee8df5505628ff6221f11cf9234 so that we can move forward with enabling Fiber support in React Native. Here, I am moving the DevTools client setup from RN repo to [React DevTools repo](https://github.com/facebook/react-devtools/blob/master/packages/react-devtools-core/README.md#requirereact-devtools-coreconnecttodevtoolsoptions) so that we can keep it in sync with the rest of React DevTools. This is also a part of a larger effort to consolidate DevTools code (facebook/react-devtools#489). It allows us to remove the double injection of the hook, an lets us replace the `eval` hack with a regular dependency. The implementation [lives here now](https://github.com/facebook/react-devtools/blob/master/packages/react-devtools-core/src/backend.js). This change re-enables Nuclide Inspector with React Native Stack reconciler and prepares it for compatibi Closes facebook/react-native#12316 Reviewed By: zertosh Differential Revision: D4545322 Pulled By: gaearon fbshipit-source-id: ab949916c1a92c6b41cd41e7e1edf9697a71de2e
1 parent 9fa5802 commit 30c01b1

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

server/runServer.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ function runServer(args, config, readyCallback) {
6969

7070
wsProxy = webSocketProxy.attachToServer(serverInstance, '/debugger-proxy');
7171
ms = messageSocket.attachToServer(serverInstance, '/message');
72-
webSocketProxy.attachToServer(serverInstance, '/devtools');
7372
inspectorProxy.attachToServer(serverInstance, '/inspector');
7473
readyCallback();
7574
}

0 commit comments

Comments
 (0)