Merge pull request #205 from clue-labs/ext-event-windows

Fix unsupported EventConfig and SEGFAULTs on shutdown for ext-event on Windows

Author: WyriHaximus

.travis.yml

@@ -37,6 +37,20 @@ matrix:
         - export PATH="$(powershell -Command '("Process", "Machine" | % { [Environment]::GetEnvironmentVariable("PATH", $_) -Split ";" -Replace "\\$", "" } | Select -Unique | % { cygpath $_ }) -Join ":"')"
       install:
         - composer install
+    - name: "Windows PHP 7.2 with ext-event"
+      os: windows
+      language: shell # no built-in php support
+      before_install:
+        - curl -OL https://windows.php.net/downloads/pecl/releases/event/2.5.3/php_event-2.5.3-7.2-nts-vc15-x64.zip # latest version as of 2019-12-23
+        - choco install php --version=7.2.26 # latest version supported by ext-event as of 2019-12-23
+        - choco install composer
+        - export PATH="$(powershell -Command '("Process", "Machine" | % { [Environment]::GetEnvironmentVariable("PATH", $_) -Split ";" -Replace "\\$", "" } | Select -Unique | % { cygpath $_ }) -Join ":"')"
+        - php -r "\$z=new ZipArchive();\$z->open(glob('php_event*.zip')[0]);\$z->extractTo(dirname(php_ini_loaded_file()).'/ext','php_event.dll');"
+        - php -r "file_put_contents(php_ini_loaded_file(),'extension_dir=ext'.PHP_EOL,FILE_APPEND);"
+        - php -r "file_put_contents(php_ini_loaded_file(),'extension=sockets'.PHP_EOL,FILE_APPEND);" # ext-sockets needs to be loaded before ext-event
+        - php -r "file_put_contents(php_ini_loaded_file(),'extension=event'.PHP_EOL,FILE_APPEND);"
+      install:
+        - composer install
   allow_failures:
     - php: hhvm
     - os: windows

src/ExtEventLoop.php

@@ -5,7 +5,6 @@
 use BadMethodCallException;
 use Event;
 use EventBase;
-use EventConfig as EventBaseConfig;
 use React\EventLoop\Tick\FutureTickQueue;
 use React\EventLoop\Timer\Timer;
 use SplObjectStorage;
@@ -43,8 +42,13 @@ public function __construct()
             throw new BadMethodCallException('Cannot create ExtEventLoop, ext-event extension missing');
         }
 
-        $config = new EventBaseConfig();
-        $config->requireFeatures(EventBaseConfig::FEATURE_FDS);
+        // support arbitrary file descriptors and not just sockets
+        // Windows only has limited file descriptor support, so do not require this (will fail otherwise)
+        // @link http://www.wangafu.net/~nickm/libevent-book/Ref2_eventbase.html#_setting_up_a_complicated_event_base
+        $config = new \EventConfig();
+        if (\DIRECTORY_SEPARATOR !== '\\') {
+            $config->requireFeatures(\EventConfig::FEATURE_FDS);
+        }
 
         $this->eventBase = new EventBase($config);
         $this->futureTickQueue = new FutureTickQueue();
@@ -55,6 +59,17 @@ public function __construct()
         $this->createStreamCallback();
     }
 
+    public function __destruct()
+    {
+        // explicitly clear all references to Event objects to prevent SEGFAULTs on Windows
+        foreach ($this->timerEvents as $timer) {
+            $this->timerEvents->detach($timer);
+        }
+
+        $this->readEvents = array();
+        $this->writeEvents = array();
+    }
+
     public function addReadStream($stream, $listener)
     {
         $key = (int) $stream;