Skip to content

Fix ClusterCommandProtocol not itself being marked as a protocol #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2023
Merged

Fix ClusterCommandProtocol not itself being marked as a protocol #2729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a15df2
Fix `ClusterCommandProtocol` not itself being marked as a protocol
Avasam Apr 30, 2023
17f717d
Update CHANGES
Avasam Apr 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
* Added a replacement for the default cluster node in the event of failure (#2463)
* Fix for Unhandled exception related to self.host with unix socket (#2496)
* Improve error output for master discovery
* Make `ClusterCommandsProtocol` an actual Protocol

* 4.1.3 (Feb 8, 2022)
* Fix flushdb and flushall (#1926)
Expand Down
2 changes: 1 addition & 1 deletion redis/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def execute_command(self, *args, **options):
...


class ClusterCommandsProtocol(CommandsProtocol):
class ClusterCommandsProtocol(CommandsProtocol, Protocol):
encoder: Union["AsyncEncoder", "Encoder"]

def execute_command(self, *args, **options) -> Union[Any, Awaitable]:
Expand Down