feat(compose): optimize one function case #1701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/compose.js
Outdated
| export default function compose(...funcs) { | ||
| if (funcs.length === 0) { | ||
| const { length } = funcs | ||
| if (!length) { |
Member
There was a problem hiding this comment.
I'd remove this variable extraction. You don't use it below. It's an unnecessary optimization.
Member
|
Neat. The branching reads a bit better this way IMHO. Can you add a test against the new return? |
Contributor
Author
|
Done. |
dsomel21
reviewed
Jun 14, 2017
| */ | ||
|
|
||
| export default function compose(...funcs) { | ||
| if (funcs.length === 0) { |
Contributor
There was a problem hiding this comment.
Yep. It's strict equality.
seantcoyote
pushed a commit
to seantcoyote/redux
that referenced
this pull request
Jan 14, 2018
* feat(compose): optimize one function case * style(compose): do not use a variable for funcs.length * test(compose): add test for a single param
This was referenced Mar 9, 2020
This was referenced Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.