Skip to content

Add Dict.has & improve Dict helpers performance #7316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 6, 2025
Merged

Add Dict.has & improve Dict helpers performance #7316

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a89c034
Optimise Dict.forEachWithKey
DZakh Feb 25, 2025
69c95ce
Speedup Dict.mapValues by 15%
DZakh Feb 25, 2025
0215326
Add Dict.has
DZakh Feb 25, 2025
eb60dfe
Update changelog
DZakh Feb 25, 2025
391e05c
Merge branch 'master' into improve-stdlib-dict
DZakh Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/es6/Stdlib_Dict.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,13 @@ function forEach(dict, f) {
}

function forEachWithKey(dict, f) {
Object.entries(dict).forEach(param => f(param[1], param[0]));
Object.keys(dict).forEach(key => f(dict[key], key));
}

function mapValues(dict, f) {
let target = {};
forEachWithKey(dict, (value, key) => {
Object.keys(dict).forEach(key => {
let value = dict[key];
Comment on lines +18 to +19
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ~15% faster. let value looks weird though

https://jsbenchmark.com/#eyJjYXNlcyI6W3siaWQiOiJWdEx6SzlYNG9fejF0WXQwSG43VWIiLCJjb2RlIjoiY29uc3QgZiA9IGEgPT4gYVxuZnVuY3Rpb24gZm9yRWFjaFdpdGhLZXkoZGljdCwgZikge1xuICBPYmplY3Qua2V5cyhkaWN0KS5mb3JFYWNoKGtleSA9PiBmKGRpY3Rba2V5XSwga2V5KSk7XG59XG5sZXQgdGFyZ2V0ID0ge307XG5mb3JFYWNoV2l0aEtleShEQVRBLCAodmFsdWUsIGtleSkgPT4ge1xuICB0YXJnZXRba2V5XSA9IGYodmFsdWUpO1xufSk7XG5yZXR1cm4gdGFyZ2V0OyIsImRlcGVuZGVuY2llcyI6W3sidXJsIjoiIiwibmFtZSI6IiIsImVzbSI6ZmFsc2V9XSwibmFtZSI6ImZ1bmN0aW9uIn0seyJpZCI6ImdYTm1TSU1rNUEwS2hLVW1PeU1HeCIsImNvZGUiOiJjb25zdCBmID0gYSA9PiBhXG5mdW5jdGlvbiBmb3JFYWNoV2l0aEtleShkaWN0LCBmKSB7XG4gIE9iamVjdC5rZXlzKGRpY3QpLmZvckVhY2goa2V5ID0-IGYoZGljdFtrZXldLCBrZXkpKTtcbn1cbmxldCB0YXJnZXQgPSB7fTtcbk9iamVjdC5rZXlzKERBVEEpLmZvckVhY2goa2V5ID0-IHtcbiAgbGV0IHZhbHVlID0gREFUQVtrZXldO1xuICB0YXJnZXRba2V5XSA9IGYodmFsdWUpO1xufSk7XG5yZXR1cm4gdGFyZ2V0OyIsImRlcGVuZGVuY2llcyI6W3sidXJsIjoiIiwibmFtZSI6IiIsImVzbSI6ZmFsc2V9XSwibmFtZSI6ImlubGluZSJ9XSwiY29uZmlnIjp7Im5hbWUiOiJCYXNpYyBleGFtcGxlIiwicGFyYWxsZWwiOnRydWUsImdsb2JhbFRlc3RDb25maWciOnsiZGVwZW5kZW5jaWVzIjpbXX0sImRhdGFDb2RlIjoicmV0dXJuIHtcbiAgXCJhXCI6IDEsXG4gIFwiYlwiOiB0cnVlLFxuICBcImNcIjogXCJmb29cIlxufSJ9fQ

target[key] = f(value);
});
return target;
Expand Down
5 changes: 3 additions & 2 deletions lib/js/Stdlib_Dict.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,13 @@ function forEach(dict, f) {
}

function forEachWithKey(dict, f) {
Object.entries(dict).forEach(param => f(param[1], param[0]));
Object.keys(dict).forEach(key => f(dict[key], key));
}

function mapValues(dict, f) {
let target = {};
forEachWithKey(dict, (value, key) => {
Object.keys(dict).forEach(key => {
let value = dict[key];
target[key] = f(value);
});
return target;
Expand Down
3 changes: 2 additions & 1 deletion runtime/Stdlib_Dict.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@ let forEach = (dict, f) => {
dict->valuesToArray->Stdlib_Array.forEach(value => f(value))
}

@inline
let forEachWithKey = (dict, f) => {
dict->toArray->Stdlib_Array.forEach(((key, value)) => f(value, key))
dict->keysToArray->Stdlib_Array.forEach(key => f(dict->getUnsafe(key), key))
}

let mapValues = (dict, f) => {
Expand Down