-
-
Notifications
You must be signed in to change notification settings - Fork 177
Introduce github actions #512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name-template: 'v$RESOLVED_VERSION' | ||
| tag-template: 'v$RESOLVED_VERSION' | ||
|
|
||
| template: | | ||
| ## General Changes | ||
|
|
||
| $CHANGES | ||
|
|
||
| categories: | ||
| - title: '🚀 Features' | ||
| labels: | ||
| - 'feature' | ||
| - 'enhancement' | ||
| - title: '🐛 Bug Fixes' | ||
| labels: | ||
| - 'fix' | ||
| - 'bugfix' | ||
| - 'bug' | ||
|
|
||
| version-resolver: | ||
| major: | ||
| labels: | ||
| - 'major' | ||
| minor: | ||
| labels: | ||
| - 'minor' | ||
| patch: | ||
| labels: | ||
| - 'patch' | ||
| default: patch | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,15 @@ | ||||||
| --- | ||||||
| name: Release Drafter Action | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. By the way, I believe we shouldn't do draft releases without waiting for the test pipeline. |
||||||
|
|
||||||
| on: | ||||||
| push: | ||||||
| branches: | ||||||
| - master | ||||||
|
|
||||||
| jobs: | ||||||
| build: | ||||||
| runs-on: ubuntu-latest | ||||||
| steps: | ||||||
| - uses: release-drafter/release-drafter@v6 | ||||||
| env: | ||||||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,56 @@ | ||||||
| --- | ||||||
| name: Test | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| on: | ||||||
| pull_request: | ||||||
| branches: | ||||||
| - master | ||||||
| release: | ||||||
| types: | ||||||
| - published | ||||||
| push: | ||||||
| branches: | ||||||
| - master | ||||||
|
|
||||||
| env: | ||||||
| REGISTRY: ghcr.io | ||||||
| IMAGE_NAME: ${{ github.repository }} | ||||||
|
Comment on lines
+14
to
+16
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These seems to be unnecessary |
||||||
|
|
||||||
| jobs: | ||||||
| test: | ||||||
| name: Docker Build | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is actually not building docker |
||||||
| runs-on: ubuntu-latest | ||||||
|
|
||||||
| steps: | ||||||
| - name: Checkout | ||||||
| uses: actions/checkout@v4 | ||||||
|
|
||||||
| - name: Setup Go | ||||||
| uses: actions/setup-go@v5 | ||||||
| with: | ||||||
| go-version-file: 'go.mod' | ||||||
| cache: false | ||||||
|
|
||||||
| # - name: Lint | ||||||
| # uses: golangci/golangci-lint-action@v6 | ||||||
| # with: | ||||||
| # args: --build-tags integration -p bugs -p unused -D protogetter --timeout=5m | ||||||
|
Comment on lines
+33
to
+36
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should add a golangci-lint config and enable this CI step |
||||||
|
|
||||||
| - name: Run unit tests | ||||||
| run: | | ||||||
| make test | ||||||
|
|
||||||
|
|
||||||
|
Comment on lines
+41
to
+42
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| # integration: | ||||||
| # runs-on: ubuntu-latest | ||||||
| # steps: | ||||||
| # - name: Checkout | ||||||
| # uses: actions/checkout@v4 | ||||||
|
|
||||||
| # - name: Setup Go | ||||||
| # uses: actions/setup-go@v5 | ||||||
| # with: | ||||||
| # go-version-file: 'go.mod' | ||||||
|
|
||||||
| # - name: Run integration tests | ||||||
| # run: | | ||||||
| # make integration | ||||||
|
Comment on lines
+43
to
+56
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this disabled because we need RethinkDB running? If yes, you may want to check https://github.com/rethinkdb/rethinkdb-python/blob/gabor/python3-v2.5.0/.github/workflows/build.yml#L27-L42 We could follow the same practice here. |
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As many use conventional commits we may want to follow those labels as well?