Minor corrections to previous submit (pandas-dev#16820)

Author: ri938

doc/source/whatsnew/v0.20.3.txt

@@ -37,7 +37,7 @@ Performance Improvements
 Bug Fixes
 ~~~~~~~~~
 - Fixed issue with dataframe scatter plot for categorical data that reports incorrect column key not found when categorical data is used for plotting (:issue:`16199`)
-- Handle reindexing an empty categorical index rather than throwing (:issue:`16770`)
+- Bug in reindexing on an empty CategoricalIndex (:issue:`16770`)
 
 
 

pandas/core/indexes/category.py

@@ -420,7 +420,7 @@ def reindex(self, target, method=None, level=None, limit=None,
 
         indexer, missing = self.get_indexer_non_unique(np.array(target))
 
-        if len(self.codes):
+        if len(indexer):
             new_target = self.take(indexer)
         else:
             new_target = target
@@ -434,8 +434,6 @@ def reindex(self, target, method=None, level=None, limit=None,
                 result = Index(np.array(self), name=self.name)
                 new_target, indexer, _ = result._reindex_non_unique(
                     np.array(target))
-                # see GH 16819, indexer needs to be converted to correct type
-                indexer = np.array(indexer, dtype=np.int64)
             else:
 
                 codes = new_target.codes.copy()

pandas/tests/indexes/test_category.py

@@ -426,7 +426,7 @@ def test_reindex_empty_index(self):
         res, indexer = c.reindex(['a', 'b'])
         tm.assert_index_equal(res, Index(['a', 'b']), exact=True)
         tm.assert_numpy_array_equal(indexer,
-                                    np.array([-1, -1], dtype=np.int64))
+                                    np.array([-1, -1], dtype=np.intp))
 
     def test_duplicates(self):