chore(api-public): add tracing to all handlers (#3199)

Author: NathanFlurry

packages/common/api-util/src/lib.rs

@@ -2,14 +2,15 @@ use anyhow::{Context, Result};
 use axum::{body::Body, response::Response};
 use futures_util::StreamExt;
 use rivet_api_builder::{ApiCtx, ErrorResponse, RawErrorResponse};
-use serde::{Serialize, de::DeserializeOwned};
+use serde::{de::DeserializeOwned, Serialize};
 use std::future::Future;
 
 mod errors;
 
 pub use axum::http::{HeaderMap, Method};
 
 /// Generic function to make raw requests to remote datacenters by label (returns axum Response)
+#[tracing::instrument(skip(ctx, headers, query, body))]
 pub async fn request_remote_datacenter_raw(
 	ctx: &ApiCtx,
 	dc_label: u16,
@@ -32,6 +33,8 @@ pub async fn request_remote_datacenter_raw(
 		url.set_query(Some(&serde_html_form::to_string(q)?));
 	}
 
+	tracing::debug!(%method, %url, "sending raw request to remote datacenter");
+
 	let mut request = client.request(method, url).headers(headers);
 
 	if let Some(b) = body {
@@ -48,6 +51,7 @@ pub async fn request_remote_datacenter_raw(
 }
 
 /// Generic function to make requests to a specific datacenter
+#[tracing::instrument(skip(config, headers, query, body))]
 pub async fn request_remote_datacenter<T>(
 	config: &rivet_config::Config,
 	dc_label: u16,
@@ -72,6 +76,8 @@ where
 		url.set_query(Some(&serde_html_form::to_string(q)?));
 	}
 
+	tracing::debug!(%method, %url, "sending request to remote datacenter");
+
 	let mut request = client.request(method, url).headers(headers);
 
 	if let Some(b) = body {
@@ -89,6 +95,7 @@ where
 
 /// Generic function to fanout requests to all datacenters and aggregate results
 /// Returns aggregated results and errors only if all requests fail
+#[tracing::instrument(skip(ctx, headers, query, local_handler, aggregator))]
 pub async fn fanout_to_datacenters<I, Q, F, Fut, A, R>(
 	ctx: ApiCtx,
 	headers: HeaderMap,
@@ -164,6 +171,7 @@ where
 	Ok(aggregated)
 }
 
+#[tracing::instrument(skip_all)]
 pub async fn reqwest_to_axum_response(reqwest_response: reqwest::Response) -> Result<Response> {
 	let status = reqwest_response.status();
 	let headers = reqwest_response.headers().clone();
@@ -178,6 +186,7 @@ pub async fn reqwest_to_axum_response(reqwest_response: reqwest::Response) -> Re
 	Ok(response)
 }
 
+#[tracing::instrument(skip_all)]
 pub async fn parse_response<T: DeserializeOwned>(reqwest_response: reqwest::Response) -> Result<T> {
 	let status = reqwest_response.status();
 	let response_text = reqwest_response.text().await?;

packages/core/api-peer/src/actors/create.rs

@@ -3,6 +3,7 @@ use gas::prelude::*;
 use rivet_api_builder::ApiCtx;
 use rivet_api_types::actors::create::{CreateQuery, CreateRequest, CreateResponse};
 
+#[tracing::instrument(skip_all)]
 pub async fn create(
 	ctx: ApiCtx,
 	_path: (),

packages/core/api-peer/src/actors/delete.rs

@@ -34,6 +34,7 @@ pub struct DeletePath {
         (status = 200, body = DeleteResponse),
     ),
 )]
+#[tracing::instrument(skip_all)]
 pub async fn delete(ctx: ApiCtx, path: DeletePath, query: DeleteQuery) -> Result<DeleteResponse> {
 	// Get the actor first to verify it exists
 	let actors_res = ctx

packages/core/api-peer/src/actors/list.rs

@@ -11,6 +11,7 @@ use rivet_api_types::{actors::list::*, pagination::Pagination};
         (status = 200, body = ListResponse),
     ),
 )]
+#[tracing::instrument(skip_all)]
 pub async fn list(ctx: ApiCtx, _path: (), query: ListQuery) -> Result<ListResponse> {
 	let key = query.key;
 	let actor_ids = query.actor_ids.as_ref().map(|x| {

packages/core/api-peer/src/actors/list_names.rs

@@ -12,6 +12,7 @@ use rivet_types::actors::ActorName;
         (status = 200, body = ListNamesResponse),
     ),
 )]
+#[tracing::instrument(skip_all)]
 pub async fn list_names(
 	ctx: ApiCtx,
 	_path: (),

packages/core/api-peer/src/internal.rs

@@ -12,6 +12,7 @@ pub struct CachePurgeRequest {
 #[derive(Serialize)]
 pub struct CachePurgeResponse {}
 
+#[tracing::instrument(skip_all)]
 pub async fn cache_purge(
 	ctx: ApiCtx,
 	_path: (),
@@ -30,6 +31,7 @@ pub async fn cache_purge(
 #[derive(Serialize)]
 pub struct BumpServerlessAutoscalerResponse {}
 
+#[tracing::instrument(skip_all)]
 pub async fn bump_serverless_autoscaler(
 	ctx: ApiCtx,
 	_path: (),

packages/core/api-peer/src/lib.rs

@@ -11,6 +11,7 @@ pub mod runners;
 
 pub use router::router as create_router;
 
+#[tracing::instrument(skip_all)]
 pub async fn start(config: rivet_config::Config, pools: rivet_pools::Pools) -> Result<()> {
 	let host = config.api_peer().host();
 	let port = config.api_peer().port();

packages/core/api-peer/src/namespaces.rs

@@ -6,6 +6,7 @@ use rivet_util::Id;
 use serde::{Deserialize, Serialize};
 use utoipa::ToSchema;
 
+#[tracing::instrument(skip_all)]
 pub async fn list(ctx: ApiCtx, _path: (), query: ListQuery) -> Result<ListResponse> {
 	let namespace_ids = query.namespace_ids.as_ref().map(|x| {
 		x.split(',')
@@ -72,6 +73,7 @@ pub struct CreateResponse {
 	pub namespace: rivet_types::namespaces::Namespace,
 }
 
+#[tracing::instrument(skip_all)]
 pub async fn create(
 	ctx: ApiCtx,
 	_path: (),

packages/core/api-peer/src/router.rs

@@ -2,6 +2,7 @@ use rivet_api_builder::{create_router, prelude::*};
 
 use crate::{actors, internal, namespaces, runner_configs, runners};
 
+#[tracing::instrument(skip_all)]
 pub async fn router(
 	name: &'static str,
 	config: rivet_config::Config,

packages/core/api-peer/src/runner_configs.rs

@@ -6,6 +6,7 @@ use rivet_types::keys::namespace::runner_config::RunnerConfigVariant;
 use serde::{Deserialize, Serialize};
 use utoipa::{IntoParams, ToSchema};
 
+#[tracing::instrument(skip_all)]
 pub async fn list(ctx: ApiCtx, _path: ListPath, query: ListQuery) -> Result<ListResponse> {
 	let namespace = ctx
 		.op(namespace::ops::resolve_for_name_global::Input {
@@ -94,6 +95,7 @@ pub struct UpsertRequest(pub rivet_api_types::namespaces::runner_configs::Runner
 #[schema(as = RunnerConfigsUpsertResponse)]
 pub struct UpsertResponse {}
 
+#[tracing::instrument(skip_all)]
 pub async fn upsert(
 	ctx: ApiCtx,
 	path: UpsertPath,
@@ -134,6 +136,7 @@ pub struct DeletePath {
 #[schema(as = RunnerConfigsDeleteResponse)]
 pub struct DeleteResponse {}
 
+#[tracing::instrument(skip_all)]
 pub async fn delete(ctx: ApiCtx, path: DeletePath, query: DeleteQuery) -> Result<DeleteResponse> {
 	let namespace = ctx
 		.op(namespace::ops::resolve_for_name_global::Input {