chore: throw error if attempting to create actor multiple times

Author: NathanFlurry

packages/actor-core/src/actor/errors.ts

@@ -254,6 +254,16 @@ export class ActorNotFound extends ActorError {
 	}
 }
 
+export class ActorAlreadyExists extends ActorError {
+	constructor(name: string, key: string[]) {
+		super(
+			"actor_already_exists", 
+			`Actor already exists with name "${name}" and key ${JSON.stringify(key)}`,
+			{ public: true }
+		);
+	}
+}
+
 export class ProxyError extends ActorError {
 	constructor(operation: string, error?: unknown) {
 		super(

packages/actor-core/src/test/driver/manager.ts

@@ -6,7 +6,9 @@ import type {
 	GetWithKeyInput,
 	ManagerDriver,
 } from "@/driver-helpers/mod";
+import { ActorAlreadyExists } from "@/actor/errors";
 import type { TestGlobalState } from "./global-state";
+import * as crypto from "node:crypto";
 import { ManagerInspector } from "@/inspector/manager";
 import type { ActorCoreApp } from "@/app/mod";
 
@@ -117,6 +119,12 @@ export class TestManagerDriver implements ManagerDriver {
 		name,
 		key,
 	}: CreateActorInput): Promise<CreateActorOutput> {
+		// Check if actor with the same name and key already exists
+		const existingActor = await this.getWithKey({ name, key });
+		if (existingActor) {
+			throw new ActorAlreadyExists(name, key);
+		}
+
 		const actorId = crypto.randomUUID();
 		this.#state.createActor(actorId, name, key);
 

packages/drivers/file-system/src/manager.ts

@@ -7,6 +7,7 @@ import type {
 	GetWithKeyInput,
 	ManagerDriver,
 } from "actor-core/driver-helpers";
+import { ActorAlreadyExists } from "actor-core/actor/errors";
 import { logger } from "./log";
 import type { FileSystemGlobalState } from "./global-state";
 import type { ActorCoreApp } from "actor-core";
@@ -95,6 +96,12 @@ export class FileSystemManagerDriver implements ManagerDriver {
 		name,
 		key,
 	}: CreateActorInput): Promise<CreateActorOutput> {
+		// Check if actor with the same name and key already exists
+		const existingActor = await this.getWithKey({ name, key });
+		if (existingActor) {
+			throw new ActorAlreadyExists(name, key);
+		}
+
 		const actorId = crypto.randomUUID();
 		await this.#state.createActor(actorId, name, key);
 

packages/drivers/memory/src/manager.ts

@@ -6,7 +6,9 @@ import type {
 	GetWithKeyInput,
 	ManagerDriver,
 } from "actor-core/driver-helpers";
+import { ActorAlreadyExists } from "actor-core/actor/errors";
 import type { MemoryGlobalState } from "./global-state";
+import * as crypto from "node:crypto";
 import { ManagerInspector } from "actor-core/inspector";
 import type { ActorCoreApp } from "actor-core";
 
@@ -86,6 +88,12 @@ export class MemoryManagerDriver implements ManagerDriver {
 		name,
 		key,
 	}: CreateActorInput): Promise<CreateActorOutput> {
+		// Check if actor with the same name and key already exists
+		const existingActor = await this.getWithKey({ name, key });
+		if (existingActor) {
+			throw new ActorAlreadyExists(name, key);
+		}
+
 		const actorId = crypto.randomUUID();
 		this.#state.createActor(actorId, name, key);
 

packages/drivers/redis/src/manager.ts

@@ -6,7 +6,9 @@ import type {
 	GetWithKeyInput,
 	ManagerDriver,
 } from "actor-core/driver-helpers";
+import { ActorAlreadyExists } from "actor-core/actor/errors";
 import type Redis from "ioredis";
+import * as crypto from "node:crypto";
 import { KEYS } from "./keys";
 import { ManagerInspector } from "actor-core/inspector";
 import type { ActorCoreApp } from "actor-core";
@@ -93,6 +95,12 @@ export class RedisManagerDriver implements ManagerDriver {
 		name,
 		key,
 	}: CreateActorInput): Promise<CreateActorOutput> {
+		// Check if actor with the same name and key already exists
+		const existingActor = await this.getWithKey({ name, key });
+		if (existingActor) {
+			throw new ActorAlreadyExists(name, key);
+		}
+
 		const actorId = crypto.randomUUID();
 		const actorKeyRedisKey = this.#generateActorKeyRedisKey(name, key);
 

packages/platforms/cloudflare-workers/src/manager-driver.ts

@@ -5,6 +5,7 @@ import type {
 	CreateActorInput,
 	GetActorOutput,
 } from "actor-core/driver-helpers";
+import { ActorAlreadyExists } from "actor-core/actor/errors";
 import { Bindings } from "./mod";
 import { logger } from "./log";
 import { serializeNameAndKey, serializeKey } from "./util";
@@ -112,6 +113,12 @@ export class CloudflareWorkersManagerDriver implements ManagerDriver {
 		if (!c) throw new Error("Missing Hono context");
 		const log = logger();
 
+		// Check if actor with the same name and key already exists
+		const existingActor = await this.getWithKey({ c, name, key });
+		if (existingActor) {
+			throw new ActorAlreadyExists(name, key);
+		}
+
 		// Create a deterministic ID from the actor name and key
 		// This ensures that actors with the same name and key will have the same ID
 		const nameKeyString = serializeNameAndKey(name, key);

packages/platforms/rivet/src/manager-driver.ts

@@ -1,4 +1,5 @@
 import { assertUnreachable } from "actor-core/utils";
+import { ActorAlreadyExists } from "actor-core/actor/errors";
 import type {
 	ManagerDriver,
 	GetForIdInput,
@@ -121,6 +122,12 @@ export class RivetManagerDriver implements ManagerDriver {
 		key,
 		region,
 	}: CreateActorInput): Promise<GetActorOutput> {
+		// Check if actor with the same name and key already exists
+		const existingActor = await this.getWithKey({ name, key });
+		if (existingActor) {
+			throw new ActorAlreadyExists(name, key);
+		}
+
 		// Create the actor request
 		let actorLogLevel: string | undefined = undefined;
 		if (typeof Deno !== "undefined") {